adding sslkey_expirations methods in clients #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7388 +/- ##
============================================
+ Coverage 26.12% 26.13% +0.01%
Complexity 98 98
============================================
Files 648 650 +2
Lines 76280 76294 +14
Branches 90 90
============================================
+ Hits 19925 19939 +14
Misses 54520 54520
Partials 1835 1835
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srijeet0406
added
Traffic Ops
srijeet0406
reviewed
Mar 9, 2023
| * under the License. | ||
| */ | ||
|
|
||
| type SSLKeyExpirationGetResponse struct { |
There was a problem hiding this comment.
Needs a GoDoc comment for this struct
| "github.com/apache/trafficcontrol/traffic_ops/toclientlib" | ||
| ) | ||
|
|
||
| func (to *Session) GetExpiringCerts(opts RequestOptions) (tc.SSLKeyExpirationGetResponse, toclientlib.ReqInf, error) { |
| "github.com/apache/trafficcontrol/traffic_ops/toclientlib" | ||
| ) | ||
|
|
||
| func (to *Session) GetExpiringCerts(opts RequestOptions) (tc.SSLKeyExpirationGetResponse, toclientlib.ReqInf, error) { |
ocket8888
added
new feature
srijeet0406
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sslkey_expirations methodology to v4 and v5 clients
Closes: #7387
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
to verify this PR, call GetExipiringCerts using TC client
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist