-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding sslkey_expirations methods in clients #7388
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package tc | ||
|
||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
// SSLKeyExpirationGetResponse is the format of a response to a GET request for API /sslkey_expirations endpoint. | ||
type SSLKeyExpirationGetResponse struct { | ||
Response []SSLKeyExpirationInformation `json:"response"` | ||
Alerts | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
package v4 | ||
|
||
/* | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
import ( | ||
"net/http" | ||
"net/url" | ||
"testing" | ||
|
||
"github.com/apache/trafficcontrol/lib/go-tc" | ||
"github.com/apache/trafficcontrol/traffic_ops/testing/api/utils" | ||
client "github.com/apache/trafficcontrol/traffic_ops/v4-client" | ||
) | ||
|
||
func TestSSLExpirations(t *testing.T) { | ||
|
||
if !includeSystemTests { | ||
t.Skip() | ||
} | ||
|
||
methodTests := utils.TestCase[client.Session, client.RequestOptions, struct{}]{ | ||
"GET": { | ||
"OK when VALID request": { | ||
ClientSession: TOSession, | ||
Expectations: utils.CkRequest(utils.NoError(), utils.HasStatus(http.StatusOK)), | ||
}, | ||
"OK when VALID DAYS PARAMETER": { | ||
ClientSession: TOSession, | ||
RequestOpts: client.RequestOptions{QueryParameters: url.Values{"days": {"30"}}}, | ||
Expectations: utils.CkRequest(utils.NoError(), utils.HasStatus(http.StatusOK)), | ||
}, | ||
"UNAUTHORIZED when NOT LOGGED IN": { | ||
ClientSession: NoAuthTOSession, | ||
Expectations: utils.CkRequest(utils.HasError(), utils.HasStatus(http.StatusUnauthorized)), | ||
}, | ||
}, | ||
} | ||
|
||
for method, testCases := range methodTests { | ||
t.Run(method, func(t *testing.T) { | ||
for name, testCase := range testCases { | ||
switch method { | ||
case "GET": | ||
t.Run(name, func(t *testing.T) { | ||
resp, reqInf, err := testCase.ClientSession.GetExpiringCerts(testCase.RequestOpts) | ||
for _, check := range testCase.Expectations { | ||
check(t, reqInf, resp, tc.Alerts{}, err) | ||
} | ||
}) | ||
} | ||
} | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
package v5 | ||
|
||
/* | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
import ( | ||
"net/http" | ||
"net/url" | ||
"testing" | ||
|
||
"github.com/apache/trafficcontrol/lib/go-tc" | ||
"github.com/apache/trafficcontrol/traffic_ops/testing/api/utils" | ||
client "github.com/apache/trafficcontrol/traffic_ops/v5-client" | ||
) | ||
|
||
func TestSSLExpirations(t *testing.T) { | ||
|
||
if !includeSystemTests { | ||
t.Skip() | ||
} | ||
|
||
methodTests := utils.TestCase[client.Session, client.RequestOptions, struct{}]{ | ||
"GET": { | ||
"OK when VALID request": { | ||
ClientSession: TOSession, | ||
Expectations: utils.CkRequest(utils.NoError(), utils.HasStatus(http.StatusOK)), | ||
}, | ||
"OK when VALID DAYS PARAMETER": { | ||
ClientSession: TOSession, | ||
RequestOpts: client.RequestOptions{QueryParameters: url.Values{"days": {"30"}}}, | ||
Expectations: utils.CkRequest(utils.NoError(), utils.HasStatus(http.StatusOK)), | ||
}, | ||
"UNAUTHORIZED when NOT LOGGED IN": { | ||
ClientSession: NoAuthTOSession, | ||
Expectations: utils.CkRequest(utils.HasError(), utils.HasStatus(http.StatusUnauthorized)), | ||
}, | ||
}, | ||
} | ||
|
||
for method, testCases := range methodTests { | ||
t.Run(method, func(t *testing.T) { | ||
for name, testCase := range testCases { | ||
switch method { | ||
case "GET": | ||
t.Run(name, func(t *testing.T) { | ||
resp, reqInf, err := testCase.ClientSession.GetExpiringCerts(testCase.RequestOpts) | ||
for _, check := range testCase.Expectations { | ||
check(t, reqInf, resp, tc.Alerts{}, err) | ||
} | ||
}) | ||
} | ||
} | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
// Package client provides Go bindings to the Traffic Ops RPC API. | ||
package client | ||
|
||
import ( | ||
"github.com/apache/trafficcontrol/lib/go-tc" | ||
"github.com/apache/trafficcontrol/traffic_ops/toclientlib" | ||
) | ||
|
||
// GetExpiringCerts gets the exiring certs within the days if 'days' param is passed | ||
// or the full list of all Delivery services and there expirations | ||
func (to *Session) GetExpiringCerts(opts RequestOptions) (tc.SSLKeyExpirationGetResponse, toclientlib.ReqInf, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needs a GoDoc comment |
||
const sslKeyExpirations = "/sslkey_expirations" | ||
|
||
var data tc.SSLKeyExpirationGetResponse | ||
|
||
reqInf, err := to.get(sslKeyExpirations, opts, &data) | ||
return data, reqInf, err | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
// Package client provides Go bindings to the Traffic Ops RPC API. | ||
package client | ||
|
||
import ( | ||
"github.com/apache/trafficcontrol/lib/go-tc" | ||
"github.com/apache/trafficcontrol/traffic_ops/toclientlib" | ||
) | ||
|
||
// GetExpiringCerts gets the exiring certs within the days if 'days' param is passed | ||
// or the full list of all Delivery services and there expirations | ||
func (to *Session) GetExpiringCerts(opts RequestOptions) (tc.SSLKeyExpirationGetResponse, toclientlib.ReqInf, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
const sslKeyExpirations = "/sslkey_expirations" | ||
|
||
var data tc.SSLKeyExpirationGetResponse | ||
|
||
reqInf, err := to.get(sslKeyExpirations, opts, &data) | ||
return data, reqInf, err | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a GoDoc comment for this struct