[Rust] Clean up conversions between TVM and Rust functions #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clone one less time - Don't panic if number of args is wrong, return an error - Actually drop functions/closures on the rust side
jroesch
approved these changes
Jul 22, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* Replace ToBoxedFn with From * Compact and improve Typed and ToFunction impls - Clone one less time - Don't panic if number of args is wrong, return an error - Actually drop functions/closures on the rust side * Retry
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* Replace ToBoxedFn with From * Compact and improve Typed and ToFunction impls - Clone one less time - Don't panic if number of args is wrong, return an error - Actually drop functions/closures on the rust side * Retry
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
* Replace ToBoxedFn with From * Compact and improve Typed and ToFunction impls - Clone one less time - Don't panic if number of args is wrong, return an error - Actually drop functions/closures on the rust side * Retry
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
* Replace ToBoxedFn with From * Compact and improve Typed and ToFunction impls - Clone one less time - Don't panic if number of args is wrong, return an error - Actually drop functions/closures on the rust side * Retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up conversions between TVM's
Functionand Rust functions.The
ToBoxedFntrait is removed entirely, replaced by standardFromimplementations.The
ToFunctionandTypedtraits have more logic, so they stay, but I've added the following:I've also macro-ified some impls to make them easier to maintain, and I've added some tests to the function conversion logic that checks error handling.