Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Clean up conversions between TVM and Rust functions #6114

Merged
merged 3 commits into from
Jul 23, 2020
Merged

[Rust] Clean up conversions between TVM and Rust functions #6114

merged 3 commits into from
Jul 23, 2020

Commits on Jul 22, 2020

  1. Replace ToBoxedFn with From

    @mwillsey
    mwillsey committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    8b9c5b1 View commit details
    Browse the repository at this point in the history

  2. Compact and improve Typed and ToFunction impls 

    - Clone one less time
- Don't panic if number of args is wrong, return an error
- Actually drop functions/closures on the rust side
    @mwillsey
    mwillsey committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    53bc523 View commit details
    Browse the repository at this point in the history

  3. Retry

    @mwillsey
    mwillsey committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    490bbb8 View commit details
    Browse the repository at this point in the history