[µTVM] Add platform timer and RPCTimeEvaluator to enable AutoTVM #6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areusch
force-pushed
the
utvm-platform-timer
branch
3 times, most recently
from
27b1561
to
f464ee6
Compare
areusch
force-pushed
the
utvm-platform-timer
branch
from
f464ee6
to
b0dc298
Compare
tmoreau89
reviewed
Dec 16, 2020
| @@ -43,7 +43,7 @@ | |||
| #define TVM_CRT_MAX_REGISTERED_MODULES 2 | |||
|
|
|||
| /*! Size of the global function registry, in bytes. */ | |||
| #define TVM_CRT_GLOBAL_FUNC_REGISTRY_SIZE_BYTES 200 | |||
| #define TVM_CRT_GLOBAL_FUNC_REGISTRY_SIZE_BYTES 256 | |||
There was a problem hiding this comment.
out of curiosity, what's the reason for increasing the registry size? just having a nice power of 2?
|
@liangfu care to take a pass? thanks! |
liangfu
requested changes
Dec 16, 2020
There was a problem hiding this comment.
The changes look good, except for a minor change request.
On the other hand, I think it's time to consider using a goto chain when leaving a function on error, since we could easily leave the function with a memory leak in C implementation.
|
ping @areusch |
|
sorry @liangfu for the delay. i've addressed your comment and sync'd to main. |
liangfu
approved these changes
Dec 25, 2020
|
@tqchen I think this is ready to merge |
|
@liangfu @tmoreau89 feel free to merge next time given both committer approves :) no need to block on myself |
This was referenced Jan 4, 2021
tkonolige
pushed a commit
to tkonolige/incubator-tvm
that referenced
this pull request
Jan 11, 2021
…che#6964) * Add platform timer to microTVM. * Address liangfu comments * cppformat * clang-format Co-authored-by: Liangfu Chen <[email protected]>
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
…che#6964) * Add platform timer to microTVM. * Address liangfu comments * cppformat * clang-format Co-authored-by: Liangfu Chen <[email protected]>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
…che#6964) * Add platform timer to microTVM. * Address liangfu comments * cppformat * clang-format Co-authored-by: Liangfu Chen <[email protected]>
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…che#6964) * Add platform timer to microTVM. * Address liangfu comments * cppformat * clang-format Co-authored-by: Liangfu Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a platform-specific timing function plus a device-side implementation of RPCTimeEvaluator. In a follow-on, an AutoTVM test will be added (there are a few different dependent PRs in flight here so need to let them all land before I can test that properly).