[BUGFIX] Change debug_runtime to represent times in seconds internally #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenGene
approved these changes
Jan 8, 2021
|
Thanks! |
jcf94
approved these changes
Jan 8, 2021
tkonolige
pushed a commit
to tkonolige/incubator-tvm
that referenced
this pull request
Jan 11, 2021
apache#7227) * Add FrontendTestModule, a Module which can have Python functions. * fix units and use of scientific notation in debug_runtime variable names * remaining updates to formalize debug_runtime returns time in sec * Add test for debug runtime output * black format * git-clang-format * pylint
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 14, 2021
apache#7227) * Add FrontendTestModule, a Module which can have Python functions. * fix units and use of scientific notation in debug_runtime variable names * remaining updates to formalize debug_runtime returns time in sec * Add test for debug runtime output * black format * git-clang-format * pylint
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
apache#7227) * Add FrontendTestModule, a Module which can have Python functions. * fix units and use of scientific notation in debug_runtime variable names * remaining updates to formalize debug_runtime returns time in sec * Add test for debug runtime output * black format * git-clang-format * pylint
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
apache#7227) * Add FrontendTestModule, a Module which can have Python functions. * fix units and use of scientific notation in debug_runtime variable names * remaining updates to formalize debug_runtime returns time in sec * Add test for debug runtime output * black format * git-clang-format * pylint
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
apache#7227) * Add FrontendTestModule, a Module which can have Python functions. * fix units and use of scientific notation in debug_runtime variable names * remaining updates to formalize debug_runtime returns time in sec * Add test for debug runtime output * black format * git-clang-format * pylint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #7197 and #6964, and fix #7207.
DebugRuntime used to represent runtimes as doubles but in microseconds. An unintentionally merged part of #6964 migrated the timing parts to use seconds, but the display parts continued to use microseconds. This patch completes the migration and adds a test. We don't have to migrate this, but it's weird to me to store runtime in double, but not store it in seconds. At least, the units should be made clear in the code.