Don't fuse take with dynamic inputs #6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
reviewed
Nov 26, 2020
masahi
reviewed
Nov 26, 2020
masahi
approved these changes
Nov 26, 2020
mbrookhart
force-pushed
the
dynamic_take
branch
from
3728238
to
45a4ccd
Compare
|
thanks @mbrookhart |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* add a regression test for fusing dynamic take * add legalize for take that stops fusion on dynamic inputs * fix lint * fix typo
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* add a regression test for fusing dynamic take * add legalize for take that stops fusion on dynamic inputs * fix lint * fix typo
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* add a regression test for fusing dynamic take * add legalize for take that stops fusion on dynamic inputs * fix lint * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6906
This stops fusion on take if it's inputs are dynamic and adds a regression test.