Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorIR][M2a] Compute-Inline,Reverse-Compute-Inline #8170

Merged
merged 1 commit into from
Jun 4, 2021
Merged

[TensorIR][M2a] Compute-Inline,Reverse-Compute-Inline #8170

merged 1 commit into from
Jun 4, 2021

Conversation

junrushao
Copy link
Member

This PR is part of the TensorIR upstreaming effort (#7527), which adds the first 2 schedule primitives:

  • compute-Inline
  • reverse-compute-inline

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly nits.

src/support/array.h Outdated Show resolved Hide resolved
src/tir/schedule/analysis.h Show resolved Hide resolved
src/tir/schedule/utils.h Outdated Show resolved Hide resolved
This PR is part of the TensorIR upstreaming effort (#7527), which adds the first 2 schedule primitives:

- compute-Inline
- reverse-compute-inline

Co-authored-by: Siyuan Feng <[email protected]>
Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Ruihang Lai <[email protected]>
Co-authored-by: Hongyi Jin <[email protected]>
Co-authored-by: Wuwei Lin <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
@junrushao
Copy link
Member Author

Hey sorry for the late response! I addressed the comments accordingly. Please take another look :-)

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@junrushao junrushao merged commit dd09bbb into apache:main Jun 4, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
This PR is part of the TensorIR upstreaming effort (apache#7527), which adds the first 2 schedule primitives:

- compute-Inline
- reverse-compute-inline

Co-authored-by: Siyuan Feng <[email protected]>
Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Ruihang Lai <[email protected]>
Co-authored-by: Hongyi Jin <[email protected]>
Co-authored-by: Wuwei Lin <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
This PR is part of the TensorIR upstreaming effort (apache#7527), which adds the first 2 schedule primitives:

- compute-Inline
- reverse-compute-inline

Co-authored-by: Siyuan Feng <[email protected]>
Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Ruihang Lai <[email protected]>
Co-authored-by: Hongyi Jin <[email protected]>
Co-authored-by: Wuwei Lin <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants