Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[M2a][TensorIR] Reduction Factoring #380

Merged
merged 1 commit into from
Jul 23, 2021
Merged

[M2a][TensorIR] Reduction Factoring #380

merged 1 commit into from
Jul 23, 2021

Conversation

MasterJH5574
Copy link
Collaborator

@MasterJH5574 MasterJH5574 commented May 3, 2021 •
edited
Loading

This PR is ready for review 🥳. For those TODO items in the code, I will update them in the future.

cc @tqchen @Hzfengsy @junrushao1994 @jinhongyii @spectrometerHBH @vinx13

@MasterJH5574 MasterJH5574 changed the title [TensorIR][WIP] Reduction Factoring [M2a][TensorIR][WIP] Reduction Factoring May 3, 2021
@MasterJH5574 MasterJH5574 changed the title [M2a][TensorIR][WIP] Reduction Factoring [M2a][TensorIR] Reduction Factoring May 15, 2021
Hzfengsy
Hzfengsy requested changes Jun 18, 2021
View reviewed changes
Copy link
Member

@Hzfengsy Hzfengsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First quick pass. By looking through the codes, I feel exception classes are too complex. Perhaps we can find another better way?

src/tir/schedule/analysis.h Show resolved Hide resolved
src/tir/schedule/analysis/analysis.cc Outdated Show resolved Hide resolved
src/tir/schedule/analysis/analysis.cc Show resolved Hide resolved
src/tir/schedule/primitive/reduction.cc Outdated Show resolved Hide resolved
junrushao
junrushao reviewed Jun 21, 2021
View reviewed changes
include/tvm/tir/expr.h Outdated Show resolved Hide resolved
junrushao
junrushao reviewed Jun 21, 2021
View reviewed changes
include/tvm/tir/expr.h Outdated Show resolved Hide resolved
jinhongyii
jinhongyii reviewed Jun 23, 2021
View reviewed changes
include/tvm/tir/expr.h Outdated Show resolved Hide resolved
src/tir/analysis/var_touch.cc Show resolved Hide resolved
src/tir/ir/expr.cc Outdated Show resolved Hide resolved
src/tir/schedule/analysis.h Outdated Show resolved Hide resolved
src/tir/schedule/analysis/analysis.cc Show resolved Hide resolved
src/tir/schedule/analysis/analysis.cc Outdated Show resolved Hide resolved
src/tir/schedule/primitive/reduction.cc Outdated Show resolved Hide resolved
junrushao
junrushao reviewed Jun 24, 2021
View reviewed changes
src/tir/ir/expr.cc Outdated Show resolved Hide resolved
junrushao
junrushao reviewed Jun 24, 2021
View reviewed changes
src/tir/ir/expr.cc Outdated Show resolved Hide resolved
junrushao
junrushao reviewed Jun 24, 2021
View reviewed changes
src/tir/ir/expr.cc Outdated Show resolved Hide resolved
junrushao
junrushao reviewed Jun 24, 2021
View reviewed changes
src/tir/ir/expr.cc Outdated Show resolved Hide resolved
junrushao
junrushao reviewed Jun 24, 2021
View reviewed changes
src/tir/ir/expr.cc Outdated Show resolved Hide resolved
junrushao
junrushao reviewed Jun 24, 2021
View reviewed changes
src/tir/ir/expr.cc Outdated Show resolved Hide resolved
@MasterJH5574 MasterJH5574 force-pushed the m2/rfactor branch 2 times, most recently from 60b7cdd to 1f3476e Compare July 20, 2021 02:25
@junrushao
Copy link
Member

The PR is in good shape now. Let's get it merged and push to upstream

@MasterJH5574 MasterJH5574 force-pushed the m2/rfactor branch 2 times, most recently from ec324f9 to e3ab7fd Compare July 23, 2021 06:45
@junrushao junrushao merged commit 71be647 into tlc-pack:staging Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen left review comments

@junrushao junrushao junrushao left review comments

@jinhongyii jinhongyii jinhongyii left review comments

@Hzfengsy Hzfengsy Hzfengsy requested changes

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@vinx13 vinx13 Awaiting requested review from vinx13 vinx13 is a code owner

@were were Awaiting requested review from were were is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang ZihengJiang is a code owner

Assignees

@junrushao junrushao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MasterJH5574 @junrushao @tqchen @Hzfengsy @jinhongyii