Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Treat floats as float32 when passing args to offloaded kernels #9010

Merged
merged 1 commit into from
Sep 15, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/runtime/hexagon/hexagon_module.cc
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,10 @@ hexagon::ArgLayout HexagonModuleNode::BuildArgLayout(const TVMArgs& As) const {
ICHECK_EQ(static_cast<int64_t>(A), static_cast<int32_t>(A));
Args.Push(static_cast<int>(A));
break;
// 64-bit values
// As above, treat floating point values as float32.
case kDLFloat:
Args.Push(static_cast<double>(A));
ICHECK_EQ(static_cast<double>(A), static_cast<float>(static_cast<double>(A)));
Args.Push(static_cast<float>(static_cast<double>(A)));
break;

case kTVMOpaqueHandle:
Expand Down