Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.9] Fix failed lambda execution crashing coordinator #1580

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

Siegrift
Copy link
Contributor

@Siegrift Siegrift commented Dec 1, 2022

Closes #1565

@Siegrift Siegrift requested review from amarthadan and a team December 1, 2022 17:58
@Siegrift Siegrift self-assigned this Dec 1, 2022
@Siegrift Siegrift force-pushed the proper-lambda-error-handling-0.9 branch from f6697b4 to 164682a Compare December 1, 2022 17:58
@Siegrift Siegrift changed the title Fix failed lambda execution crashing coordinator [v0.9] Fix failed lambda execution crashing coordinator Dec 1, 2022
@Siegrift
Copy link
Contributor Author

Siegrift commented Dec 1, 2022

@amarthadan I wasn't able to build Docker images locally and the CI fails as well (also for the 0.9 branch). I've tried building also on Linux locally, but got an error as well.

I've tried to debug the issue, but I gave that up after a while. I 100% remember testing this and it used to work for me.
I've tested this using the deployer package directly.

@amarthadan
Copy link
Contributor

@amarthadan I wasn't able to build Docker images locally and the CI fails as well (also for the 0.9 branch). I've tried building also on Linux locally, but got an error as well.

I've tried to debug the issue, but I gave that up after a while. I 100% remember testing this and it used to work for me. I've tested this using the deployer package directly.

I'll take a look.

@amarthadan
Copy link
Contributor

Ok, found what the issue with Docker builds is, tracked and described in #1585.

@Siegrift Siegrift force-pushed the proper-lambda-error-handling-0.9 branch from d5f9980 to ee7708b Compare December 5, 2022 08:45
@Siegrift Siegrift merged commit cf382ad into v0.9 Dec 5, 2022
@Siegrift Siegrift deleted the proper-lambda-error-handling-0.9 branch December 5, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants