Merge pull request #950 from jamiter/patch-1

Catch `fetchQuery` errors in `startQuery`.

AUTHORS

@@ -21,6 +21,7 @@ Louis DeScioli <[email protected]>
 Marc-Andre Giroux <[email protected]>
 Martijn Walraven <[email protected]>
 Maxime Quandalle <[email protected]>
+Michiel ter Reehorst <[email protected]>
 Oleksandr Stubailo <[email protected]>
 Olivier Ricordeau <[email protected]>
 Pavol Fulop <[email protected]>

CHANGELOG.md

@@ -4,6 +4,8 @@ Expect active development and potentially significant breaking changes in the `0
 
 ### vNEXT
 
+- Catch uncaught promise errors in QueryManager [#950](https://github.com/apollostack/apollo-client/pull/950)
+
 ### 0.5.6
 - Refactor polling query logic to fix startPolling and stopPolling [#938](https://github.com/apollostack/apollo-client/pull/938)
 - Add convenience method to obtain initial state from SSR [#941](https://github.com/apollostack/apollo-client/pull/941)

src/core/QueryManager.ts

@@ -638,7 +638,10 @@ export class QueryManager {
   public startQuery(queryId: string, options: WatchQueryOptions, listener: QueryListener) {
     this.addQueryListener(queryId, listener);
 
-    this.fetchQuery(queryId, options);
+    this.fetchQuery(queryId, options)
+    // `fetchQuery` returns a Promise. In case of a failure it should be caucht or else the
+    // console will show an `Uncaught (in promise)` message. Ignore the error for now.
+    .catch((error: Error) => undefined);
 
     return queryId;
   }