Catch fetchQuery errors in startQuery.
#950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamiter thanks, this looks good! We should unify the way watchQuery and refetch get their errors (refetch is why the error is thrown in the first place). |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)Make sure all of the significant new logic is covered by testsIf this was a change that affects the external API, update the docs and post a link to the PR in the discussionFixes #891
The error wasn't caught anywhere. Should anything be done with the error? For subscriptions it is handled via the store I believe.