Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #713 with OptionalDependencies approach #772

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

poloagustin
Copy link
Contributor

@poloagustin poloagustin commented Oct 13, 2016

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@apollo-cla
Copy link

@poloagustin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@poloagustin poloagustin mentioned this pull request Oct 13, 2016
7 tasks
@helfer
Copy link
Contributor

helfer commented Oct 13, 2016

@poloagustin Thanks for the PR! I think we need to have it in both devDependencies and optionalDependencies.

@poloagustin
Copy link
Contributor Author

not a problem 👍

@stubailo
Copy link
Contributor

Never mind - let's have it only in optionalDependencies, just talked to Jonas

@stubailo stubailo merged commit f84bbdb into apollographql:master Oct 14, 2016
@antmdvs
Copy link

antmdvs commented Oct 14, 2016

Perhaps CHANGELOG should be updated to reflect optionalDependencies and reference the conversation in #733

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants