removed circular dep, fixed npm devDep, Angular2-AOT compatibility #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2016 17:31
- removed circular dependency in data/store.ts - added "ApolloClient" to the named exports to make it compatible with Angular2 AOT compile - moved dev @types to devDependencies otherwise they potentially brake projects that are importing apollo-client
|
@metzc: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
stubailo
reviewed
Oct 15, 2016
| @@ -43,3 +43,4 @@ matt debergalis <[email protected]> | |||
| Vladimir Guguiev <[email protected]> | |||
| Edvin Eriksson <[email protected]> | |||
| Agustin Polo <[email protected]> | |||
| Chris Metz <[email protected]> | |||
There was a problem hiding this comment.
I wondered.. isn't this openly readable for any email scanner? Also wouldn't put my address anywhere else openly. What do you think?
There was a problem hiding this comment.
Up to you. I put my real email on GitHub, but I understand not everyone wants to.
| @@ -34,7 +36,7 @@ function isVariable(value: Value): value is Variable { | |||
| return value.kind === 'Variable'; | |||
| } | |||
|
|
|||
| function isObject(value: Value): value is ObjectValue { | |||
| function isGraphObject(value: Value): value is ObjectValue { | |||
There was a problem hiding this comment.
Maybe isGraphQLObjectValue would be a good name. This looks for GraphQL object literals in the AST.
|
Merging here: #780 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: