Fix ApolloError bug and GraphQLError spec compliance #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-scheer
force-pushed
the
trevor/AS-2917
branch
from
7c637f5
to
0d878fd
Compare
* No longer allow the 'properties' object to overwrite the error message provided to the ApolloError constructor * Move ApolloError towards a GraphQLError spec compliance by using extensions rather than arbitrary properties on the class itself. Previous behavior is still supported, however it's now deprecated in favor of extensions. For more context, please read the large comment block associated with this commit.
trevor-scheer
changed the title
abernix
approved these changes
Oct 15, 2019
Co-Authored-By: Jesse Rosenberger <[email protected]>
Co-Authored-By: Jesse Rosenberger <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug with
ApolloError, as well as takes a step towardsGraphQLErrorspec compliance.Bug:
No longer allow the 'properties' (now
extensions) object to overwrite the error message provided to the ApolloError constructor.Spec complicance:
Move ApolloError towards GraphQLError spec compliance by using extensions rather than arbitrary properties on the class itself. Previous behavior is still supported, however it's now deprecated in favor of extensions. For more context, please read the large comment block associated with this PR's change set.