Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ApolloError bug and GraphQLError spec compliance #3408

Merged
merged 7 commits into from
Oct 15, 2019
Merged

Fix ApolloError bug and GraphQLError spec compliance #3408

merged 7 commits into from
Oct 15, 2019

Commits on Oct 14, 2019

  1. Add testing infrastructure for apollo-server-errors

    @trevor-scheer
    trevor-scheer committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    aa96e04 View commit details
    Browse the repository at this point in the history

  2. Initial exploration of ApolloError bug

    @trevor-scheer
    trevor-scheer committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    0d878fd View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Address ApolloError bug and non-spec compliance 

    * No longer allow the 'properties' object to overwrite the
  error message provided to the ApolloError constructor

* Move ApolloError towards a GraphQLError spec compliance by using
extensions rather than arbitrary properties on the class itself.
Previous behavior is still supported, however it's now deprecated
in favor of extensions. For more context, please read the large
comment block associated with this commit.
    @trevor-scheer
    trevor-scheer committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    0c7fbe4 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @trevor-scheer
    trevor-scheer committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    52b8b31 View commit details
    Browse the repository at this point in the history

  3. Update packages/apollo-server-errors/src/index.ts 

    Co-Authored-By: Jesse Rosenberger <[email protected]>
    @trevor-scheer @abernix
    trevor-scheer and abernix authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    f4c0a59 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md 

    Co-Authored-By: Jesse Rosenberger <[email protected]>
    @trevor-scheer @abernix
    trevor-scheer and abernix authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9ce569a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into trevor/AS-2917

    @trevor-scheer
    trevor-scheer authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    511359c View commit details
    Browse the repository at this point in the history