Relocate federation packages to new federation repository #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oving. This is a precursor to a step that will remove this code which has been moved to another repository. See #4560 for details, and follow the next commit for the removal!
Everything will continue, however, as federation becomes more independent from Apollo Server, it (and its concerns, like Apollo Gateway) move to their own repository. (It's always been relatively independent, but it didn't necessarily warrant its own repository before.) This includes `apollo-federation-integration-testsuite` (unpublished to npm), `@apollo/gateway (which lived in `packages/apollo-gateway` here and as `/gateway-js` on the new repository), and `@apollo/federation` (which lived in `packages/apollo-federation` here and as `/federation-js` on the new repository). See #4560 for details, and also apollographql/federation#134 for where (and how) it was introduced on the other side.
glasser
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
As mentioned on Slack there's a regexp in jest.config.base.js that needs updating. Assuming that doesn't break CI (and that you make the appropriate changes so that codecov won't fail on all PRs) LGTM! Thanks for getting this in today, since it'll make my current work capable of building :)
|
The Given the change we're making here, the fluctuation against base is expected and merging this should set a new baseline. (Or, alternatively, I will follow-up with a change to the |
jbaxleyiii
approved these changes
Sep 11, 2020
This was referenced Sep 16, 2020
This was referenced Sep 17, 2020
glasser
added a commit
that referenced
this pull request
Sep 22, 2020
In #4561 we removed `@apollo/federation` and `@apollo/gateway` from the apollo-server repo. This means that the acephei example doesn't know where to import them from. Adding them to examples/acephei/package.json led to very strange errors so let's just add them as top-level dev dependencies. Additionally, removing `@apollo/federation` seemed to make it so that TypeScript can't find `apollo-env` any more, but it also seems like maybe the references to it in the tsconfig.json lines aren't necessary? Not sure what's going on here but leaving them in led to build errors and removing them didn't. Finally, update the uses of `engine:` to use the new post-#4453 APIs, and spell the version "set up" as two words.
glasser
added a commit
that referenced
this pull request
Sep 22, 2020
In #4561 we removed `@apollo/federation` and `@apollo/gateway` from the apollo-server repo. This means that the acephei example doesn't know where to import them from. Adding them to examples/acephei/package.json led to very strange errors so let's just add them as top-level dev dependencies. Additionally, removing `@apollo/federation` seemed to make it so that TypeScript can't find `apollo-env` any more, but it also seems like maybe the references to it in the tsconfig.json lines aren't necessary? Not sure what's going on here but leaving them in led to build errors and removing them didn't. Finally, update the uses of `engine:` to use the new post-#4453 APIs, and spell the version "set up" as two words.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages are not going away, they're just moving to their new home on the Apollo Federation repository. This is part of the work explained in #4560 and further discussed (in technical detail) within apollographql/federation#134, which is also the PR that introduces the same code to that repository (
apollographql/federation) that this PR removes from this repository (apollographql/apollo-server).This PR and removing this code doesn't absolve us from remaining concerns that are important in this migration (existing PRs, for example), but as noted in #4560, stand-by for further progress on that (and see the related project board for details, including such concerns as moving existing issues, and addressing existing PRs).
Closes #4560