Add missing input rewrites in some case of @interfaceObject #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 62877a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
pcmanus
force-pushed
the
issue-itfObject-rewrites
branch
from
8b64d7a
to
f27f9a7
Compare
Fetches to subgraphs that use `@interfaceObject` needs to have some rewriting on their inputs to ensure we don't never send a __typename whose value is an implementation type for the `@interfaceObject` (such type is unknown to the particular subgraph). The code was doing those rewrites in most cases, but in the case where only fields from the `@interfaceObject` were requested _but_ some type condition forced the resolution of the implementation, those rewrites were not populated. It resulted in the subgraph rejecting the `_entities` call due to some of the __typename not matching any known type (by this subgraph). This commit ensures those rewrites are correctly populated.
pcmanus
force-pushed
the
issue-itfObject-rewrites
branch
from
f27f9a7
to
3c6929d
Compare
|
Note that during some testing, a small typo was found in the code that was recently added to handle the response post-processing. For speed and because it's very trivial, including it in this PR as well (see 2nd commit). |
clenfest
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches to subgraphs that use
@interfaceObjectneeds to have some rewriting on their inputs to ensure we don't never send a __typename whose value is an implementation type for the@interfaceObject(such type is unknown to the particular subgraph).The code was doing those rewrites in most cases, but in the case where only fields from the
@interfaceObjectwere requested but some type condition forced the resolution of the implementation, those rewrites were not populated. It resulted in the subgraph rejecting the_entitiescall due to some of the __typename not matching any known type (by this subgraph).This commit ensures those rewrites are correctly populated.