Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing input rewrites in some case of @interfaceObject #2346

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Add missing input rewrites in some case of @interfaceObject #2346

merged 2 commits into from
Jan 25, 2023

Commits on Jan 24, 2023

  1. Add missing input rewrites in some case of @interfaceObject 

    Fetches to subgraphs that use `@interfaceObject` needs to have some
rewriting on their inputs to ensure we don't never send a __typename
whose value is an implementation type for the `@interfaceObject` (such
type is unknown to the particular subgraph).

The code was doing those rewrites in most cases, but in the case where
only fields from the `@interfaceObject` were requested _but_ some
type condition forced the resolution of the implementation, those
rewrites were not populated. It resulted in the subgraph rejecting
the `_entities` call due to some of the __typename not matching any
known type (by this subgraph).

This commit ensures those rewrites are correctly populated.
    Sylvain Lebresne committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3c6929d View commit details
    Browse the repository at this point in the history

  2. Fix typo in result post-processing code

    Sylvain Lebresne committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    62877a5 View commit details
    Browse the repository at this point in the history