type graphql.options.skip HOC property (#2208)

* type graphql.options.skip HOC property * Changelog update * Test adjustment to accommodate type change
apollographql · Aug 22, 2018 · 3da0b0d · 3da0b0d
1 parent 8ef0b75
commit 3da0b0d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -32,6 +32,8 @@
 - Remove duplicate `FetchMoreOptions` and `FetchMoreQueryOptions` types, and
   instead import them from Apollo Client. <br/>
   [@skovy](https://github.com/skovy) in [#2281](https://github.com/apollographql/react-apollo/pull/2281)
+- Type changes for the `graphql` HOC `options.skip` property.  <br/>
+  [@jameslaneconkling](https://github.com/jameslaneconkling) in [#2208](https://github.com/apollographql/react-apollo/pull/2208)
 
 ## 2.1.11 (August 9, 2018)
 

diff --git a/src/types.ts b/src/types.ts
@@ -119,7 +119,7 @@ export interface OperationOption<
     props: OptionProps<TProps, TData, TGraphQLVariables>,
     lastProps?: TChildProps | void,
   ) => TChildProps;
-  skip?: boolean | ((props: any) => boolean);
+  skip?: boolean | ((props: TProps) => boolean);
   name?: string;
   withRef?: boolean;
   shouldResubscribe?: (props: TProps, nextProps: TProps) => boolean;

diff --git a/test/client/getDataFromTree.test.tsx b/test/client/getDataFromTree.test.tsx
@@ -754,7 +754,7 @@ describe('SSR', () => {
 
       type WithUserChildProps = ChildProps<Props, UserQueryData, UserQueryVariables>;
       const withUser = graphql<WithIdChildProps, UserQueryData, UserQueryVariables>(userQuery, {
-        skip: ({ data: { loading } }) => loading,
+        skip: ({ data }) => data!.loading,
         options: ({ data }) => ({
           variables: { id: data!.currentUser!.id },
         }),