Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

type graphql.options.skip HOC property #2208

Merged
merged 4 commits into from
Aug 22, 2018

Conversation

jameslaneconkling
Copy link
Contributor

@jameslaneconkling jameslaneconkling commented Jul 24, 2018

Fix typing for graphql() config.skip function:

Before:

  graphql<OwnProps>(QUERY, {
    skip: (ownProps) => ownProps.skip // ownProps: any
  });

After:

  graphql<OwnProps>(QUERY, {
    skip: (ownProps) => ownProps.skip // ownProps: OwnProps
  });

@apollo-cla
Copy link

@jameslaneconkling: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@hwillson hwillson added the todo label Aug 21, 2018
@hwillson hwillson self-assigned this Aug 21, 2018
@hwillson hwillson added in-progress and removed todo labels Aug 22, 2018
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea - thanks @jameslaneconkling!

@hwillson hwillson merged commit 3da0b0d into apollographql:master Aug 22, 2018
williamboman added a commit to williamboman/react-apollo that referenced this pull request Aug 29, 2018
* master: (112 commits)
  chore(deps): update dependency danger to v3.8.8
  chore(deps): update dependency enzyme to v3.5.0
  chore(deps): update dependency apollo-client to v2.4.1
  chore(deps): update dependency apollo-cache-inmemory to v1.2.9
  chore(deps): update dependency apollo-cache to v1.1.16
  chore(deps): update dependency @types/react to v16.4.12
  chore(deps): update dependency rollup-plugin-commonjs to v9.1.6
  chore(deps): update dependency @types/node to v10.9.2
  chore(deps): update dependency react-scripts to v1.1.5
  chore(deps): update dependency ts-jest to v23.1.4
  Avoid importing lodash directly (apollographql#2045)
  type graphql.options.skip HOC property (apollographql#2208)
  Replace duplicate ObservableQueryFields types defined in apollo-client (apollographql#2281)
  Make mock links mock parameter readonly (apollographql#2284)
  test-utils: allow passing a custom cache object to `MockedProvider` (apollographql#2254)
  Query: Fix data is undefined on error (apollographql#1983)
  Don't mutate options object when calculating variables from props (apollographql#1968)
  Feature: add onSubscriptionData callback to <Subscription> (apollographql#1966)
  Changelog update
  Example of a mutation including tests (apollographql#1998)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants