Package now consists of ES2015 and commonjs #1576
Conversation
rosskevin
changed the title
| @@ -90,28 +104,26 @@ | |||
| "babel-core": "6.26.0", | |||
| "babel-jest": "22.1.0", | |||
| "babel-preset-env": "1.6.1", | |||
| "bundlesize": "0.15.3", | |||
There was a problem hiding this comment.
@rosskevin why are we removing bundlesize?
There was a problem hiding this comment.
We aren't creating a UMD bundle anymore, not sure if we can size a non-compressed folder of files. I'll check.
There was a problem hiding this comment.
Added back to test rollup-produced CJS file
| "rimraf": "2.6.2", | ||
| "rollup": "0.54.1", |
There was a problem hiding this comment.
do we not need this anymore? Does typescript handle all of the bundling?
There was a problem hiding this comment.
tsc does 100% of the transpilation - no more bundles (discussed with @jaydenseric in the thread)
There was a problem hiding this comment.
rollup added back for bundlesize only
| @@ -5,37 +5,40 @@ | |||
| "module": "src/index.ts", | |||
There was a problem hiding this comment.
How does this work, does main and module get added to the package.json that actually gets published?
There was a problem hiding this comment.
ugh, that's no good
There was a problem hiding this comment.
wait, no, this is ok - it's there for codesandbox. Pay no attention to the /package.json, just to lib/package.json
|
L:ooks like the bundlesize calculation is wrong but I'll fix that on master |
|
I confirmed this PR locally with a package build using ts-loader |
|
I'm confused, I'm looking at what is published in
It should be: {
"main": "index",
"module": "index.mjs"
}We discussed minification and bundling, and agreed that it would only happen to test bundle size but no UMD or AMD would be distributed. Currently the Also, many of the .mjs files are invalid as they have I'm trying to work out what has been going on looking at the release descriptions, and they don't make sense. v2.1.0-alpha.1 and v2.1.0-alpha.2 have the exact same bullet list of changes. No release mentions |
|
@jaydenseric @jbaxleyiii changed the You should look at this changeset, it is exactly as discussed. I'll place the rest of my comments in #1589. |
As discussed in
apollo-maintainerstarget package creation to supportmainas commonjs andmoduleas ES2015./cc @jaydenseric
Closes #1575