This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Browser #1578
Merged
Browser #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbaxleyiii it looks like you removed husky - which is the |
danielkcz
reviewed
Mar 15, 2018
| @@ -3,48 +3,45 @@ | |||
| "version": "2.1.0-alpha.0", | |||
| "description": "React data container for Apollo Client", | |||
| "module": "src/index.ts", | |||
| "browser": "lib/react-apollo.browser.umd.js", | |||
There was a problem hiding this comment.
@jbaxleyiii I don't understand why this change was necessary. Doesn't it mean that eg. Webpack cannot do tree shaking? Besides it's broken altogether :) #1591 and this is from debugger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rosskevin in my testing the inclusion of react-dom blew up ReactNative and some older build systems. Also, without a single bundle, we can't support usage of unpkg.org which I'd like to keep for people using it!
This also fixes the precommit hooks with husky which weren't working previously and removes using
yarnsince its not a required part of the node ecosystem