Update how the node SDK handles self signed requests #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
approved these changes
Oct 8, 2023
lohanidamodar
approved these changes
Oct 11, 2023
The NODE_TLS_REJECT_UNAUTHORIZED env variable will disable SSL checks for all requests. This PR changes the node SDK to only disable SSL checks for Appwrite related requests by passing an option to axios.
stnguyen90
force-pushed
the
fix-6832-node-self-signed
branch
from
fe8c8db
to
a644530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The NODE_TLS_REJECT_UNAUTHORIZED env variable will disable SSL checks for all requests. This PR changes the node SDK to only disable SSL checks for Appwrite related requests by passing an option to axios.
Fixes appwrite/appwrite#6832
Test Plan
Before change:
After change:
Without calling setSelfSigned():
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes