Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how the node SDK handles self signed requests #722

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Update how the node SDK handles self signed requests #722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions templates/node/lib/client.js.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const os = require('os');
const URL = require('url').URL;
const https = require("https");
const axios = require('axios');
const FormData = require('form-data');
const {{spec.title | caseUcfirst}}Exception = require('./exception.js');
Expand Down Expand Up @@ -81,11 +82,6 @@ class Client {
}

async call(method, path = '', headers = {}, params = {}, responseType = 'json') {
if(this.selfSigned) { // Allow self signed requests
process.env["NODE_TLS_REJECT_UNAUTHORIZED"] = 0;
}


headers = Object.assign({}, this.headers, headers);

let contentType = headers['content-type'].toLowerCase();
Expand Down Expand Up @@ -125,6 +121,10 @@ class Client {
json: (contentType.startsWith('application/json')),
responseType: responseType
};
if (this.selfSigned) {
// Allow self signed requests
options.httpsAgent = new https.Agent({ rejectUnauthorized: false });
}
try {
let response = await axios(options);
return response.data;
Expand Down