fix: ipfs returned an empty string #485

heueristik · 2023-10-18T08:36:53Z

Description

Task ID: OS-776

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

I have selected the correct base branch.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
My changes generate no new warnings.
Any dependent changes have been merged and published in downstream modules.
I ran all tests with success and extended them if necessary.
I have updated the CHANGELOG.md file in the root folder.
I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
I have updated the UPDATE_CHECKLIST file in the root folder.

* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> * chore: fix merge --------- Co-authored-by: Mathias Scherer <[email protected]>

* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * docs(contracts): removes outdated step in upgrade checklist * deploy(contracts): adds v1.3.0 mainnet deployment * deploy(contracts): adds polygon deployment * fix: removes uncessary inconsistent managingDAOImplementation field from active_contracts.json * chore: bump package version to v1.3.0 * chore: updates version for osx package * chore(contracts): updates changelog * chore(contracts): updates active_contracts with implementations and bases * chore(contracts): moves line in changelog * style(contracts): applies prettier styling --------- Co-authored-by: Michael Heuer <[email protected]>

* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * docs: v1.3.0 audit files * release: deploy v1.3.0 (#509) * docs(contracts): removes outdated step in upgrade checklist * deploy(contracts): adds v1.3.0 mainnet deployment * deploy(contracts): adds polygon deployment * fix: removes uncessary inconsistent managingDAOImplementation field from active_contracts.json * chore: bump package version to v1.3.0 * chore: updates version for osx package * chore(contracts): updates changelog * chore(contracts): updates active_contracts with implementations and bases * chore(contracts): moves line in changelog * docs: replace code4rena draft by final report * docs: mention audit reports in README * docs: added missing report link and use perma links --------- Co-authored-by: Mathias Scherer <[email protected]>

* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * fix: build and release metadata where swapped * fix: publish an empty JSON object to silence the EmptyReleaseMetadata error * docs: improve checklists --------- Co-authored-by: Mathias Scherer <[email protected]>

* fix(subgraph): update to @graphprotocol/[email protected] (#453) * fix: missing virtual keyword (#452) * fix: added missing virtual keywords. * fix: correct misspelled filename * docs: improved NatSpec * chore: bump package versions * Update packages/contracts/CHANGELOG.md Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * Deploy contracts and subgraph to sepolia (#475) * feat: deploy v1.3.0-rc0 to sepolia * feat: bump subgraph version to v1.3.0-rc0 feat: deploy sepolia subgraph * fix(OS-638): fixes typo in implementation * chore: fix formatting in helpers script * fix: ipfs returned an empty string (#485) (#495) * chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496) * chore: prepared arbitrum deployment * chore: deployed v1.3.0 to arbitrumGoerli * docs: improved checklist * chore: deployed v1.3.0 to arbitrum * chore: deployed v1.3.0-rc0.4 npm packages * chore: added manifests for arbitrum and arbitrumGoerli * docs: improved deployment checklist * docs: improved deployment checklist * docs: fix typo Co-authored-by: Mathias Scherer <[email protected]> --------- Co-authored-by: Mathias Scherer <[email protected]> * release: deploy v1.3.0 (#509) * docs(contracts): removes outdated step in upgrade checklist * deploy(contracts): adds v1.3.0 mainnet deployment * deploy(contracts): adds polygon deployment * fix: removes uncessary inconsistent managingDAOImplementation field from active_contracts.json * chore: bump package version to v1.3.0 * chore: updates version for osx package * chore(contracts): updates changelog * chore(contracts): updates active_contracts with implementations and bases * chore(contracts): moves line in changelog * fix: build and release metadata mixups (#507) * fix: build and release metadata where swapped * fix: publish an empty JSON object to silence the EmptyReleaseMetadata error * docs: improve checklists * deploy: adds fqn to contract verification * deploy: corrects false fqds * chore: applies prettier formatting * chore: adds arbitrum sepolia deployment * deploy(subgraph): changes node endpoint to alchemy * feat: deploys base sepolia fix: sets fixed gas price for base networks fix: fixes wrong multisig address for arbitrum sepolia management dao * chore: adds release.md hr line Co-authored-by: Michael Heuer <[email protected]> * style: applies prettier formatting --------- Co-authored-by: Michael Heuer <[email protected]>

fix: ipfs returned an empty string

91ffa44

github-actions bot added the contracts label Oct 18, 2023

heueristik requested review from Rekard0 and mathewmeconry October 18, 2023 08:37

mathewmeconry approved these changes Oct 18, 2023

View reviewed changes

heueristik requested a review from josemarinas October 18, 2023 09:23

josemarinas approved these changes Oct 18, 2023

View reviewed changes

heueristik merged commit 5faeea6 into develop Oct 18, 2023
20 checks passed

heueristik deleted the fix/ipfs branch October 18, 2023 09:47

heueristik added a commit that referenced this pull request Oct 30, 2023

fix: ipfs returned an empty string (#485)

b67dcf7

heueristik mentioned this pull request Oct 30, 2023

fix: empty metadata caused by IPFS upload returning an empty string #495

Merged

10 tasks

Rekard0 pushed a commit that referenced this pull request Oct 30, 2023

fix: ipfs returned an empty string (#485) (#495)

61d5352

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ipfs returned an empty string #485

fix: ipfs returned an empty string #485

heueristik commented Oct 18, 2023 •

edited by jira bot

Loading

fix: ipfs returned an empty string #485

fix: ipfs returned an empty string #485

Conversation

heueristik commented Oct 18, 2023 • edited by jira bot Loading

Description

Type of change

Checklist:

heueristik commented Oct 18, 2023 •

edited by jira bot

Loading