Introduce user-defined task extended data #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equation314
force-pushed
the
task-ext
branch
from
d676300
to
15300af
Compare
hky1999
approved these changes
Sep 14, 2024
| @@ -11,7 +12,7 @@ pub fn start_secondary_cpus(primary_cpu_id: usize) { | |||
| let mut logic_cpu_id = 0; | |||
| for i in 0..SMP { | |||
| if i != primary_cpu_id { | |||
| let stack_top = virt_to_phys(va!(unsafe { | |||
| let stack_top = virt_to_phys(VirtAddr::from(unsafe { | |||
There was a problem hiding this comment.
you just revert it back (dog head manually
There was a problem hiding this comment.
I removed va and pa exports in axhal::mem, so we need to import the memory_addr dependency if use va!.
Do you think it is OK?
aarkegz
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes to
axtask:task_extfield toTaskInner, and allow users to define the specific structure via thedef_task_ext!macro.spawn_taskAPI withTaskInneras the argument.