Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show import wallet key length error #433

Merged
merged 16 commits into from
Jul 12, 2024

Conversation

pawanpaudel93
Copy link
Contributor

Summary

This PR adds the error modal shown when importing non-supported wallets other than 4096 bits wallet. Also, it adds a fix to not show the two unlock ArConnect popup after trying to open ArConnect when a new wallet is generated or imported for the first time occurring due to checkBits function.

@pawanpaudel93 pawanpaudel93 requested a review from 7i7o July 10, 2024 17:01
@pawanpaudel93 pawanpaudel93 changed the title Show import wallet creation error Show import wallet key length error Jul 10, 2024
@pawanpaudel93 pawanpaudel93 force-pushed the arc-422-import-wallet-creation-error branch from 5c9a03a to 9d11e93 Compare July 11, 2024 05:25
Copy link
Contributor

@7i7o 7i7o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 👍

@nicholaswma nicholaswma merged commit 3133d62 into development Jul 12, 2024
@nicholaswma nicholaswma deleted the arc-422-import-wallet-creation-error branch July 12, 2024 19:48
Copy link

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants