Skip to content

Commit

Permalink
Check the folder content in new version of the agent on macos (#797)
Browse files Browse the repository at this point in the history
* disable pushing autoupdate file on s3 for testing purposes
also set prerelease: true for the github release, so that we can perform tests

* we check if the bundle is already there

* fix typo

* Revert "disable pushing autoupdate file on s3 for testing purposes"

This reverts commit 61373da.
  • Loading branch information
umbynos authored Jun 9, 2023
1 parent c9c688d commit 7c88643
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ func oldInstallExists() bool {
if binIsOld {
return false
}
return oldAgentPath.Exist()
return oldAgentPath.Join("ArduinoCreateAgent.app").Exist()
}

// printDialog will print a GUI error dialog on macos
Expand Down
2 changes: 1 addition & 1 deletion updater/updater_darwin.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func checkForUpdates(currentVersion string, updateURL string, cmdName string) (s
if currentAppPath.Ext() != ".app" {
return "", fmt.Errorf("could not find app root in %s", executablePath)
}
oldAppPath := currentAppPath.Parent().Join("ArdiunoCreateAgent.old.app")
oldAppPath := currentAppPath.Parent().Join("ArduinoCreateAgent.old.app")
if oldAppPath.Exist() {
return "", fmt.Errorf("temp app already exists: %s, cannot update", oldAppPath)
}
Expand Down

0 comments on commit 7c88643

Please sign in to comment.