Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the folder content in new version of the agent on macos #797

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jun 6, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

bug fix

  • What is the current behavior?

when uninstalling an old version of the agent (e.g. 1.2.7) a folder in ~/Applications/ArduinoCreateAgent could be left behind (empty, but existing), after uninstalling.
This will trigger this error when running a new agent:

image

  • What is the new behavior?

The check in the new agent is performed on the existence of the ArduinoCreateAgent.app subfolder.

  • Does this PR introduce a breaking change?

no

  • Other information:

Partially fixes #795

@umbynos umbynos added type: enhancement Proposed improvement os: macos Specific to macOS operating system labels Jun 6, 2023
@umbynos umbynos requested a review from cmaglie June 6, 2023 10:35
@umbynos umbynos self-assigned this Jun 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (4e7b23f) 11.00% compared to head (58ee77a) 10.96%.

❗ Current head 58ee77a differs from pull request most recent head 12f5e27. Consider uploading reports for the commit 12f5e27 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   11.00%   10.96%   -0.05%     
==========================================
  Files          55       55              
  Lines        4052     4068      +16     
==========================================
  Hits          446      446              
- Misses       3551     3567      +16     
  Partials       55       55              
Flag Coverage Δ
unit 10.96% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/autostart.go 0.00% <0.00%> (ø)
main.go 2.28% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos changed the title the folder could exist but could be empty. It's better to check this way Check the folder content in new version of the agent on macos Jun 6, 2023
@umbynos
Copy link
Contributor Author

umbynos commented Jun 6, 2023

main.go Outdated Show resolved Hide resolved
@umbynos umbynos merged commit 7c88643 into main Jun 9, 2023
@umbynos umbynos deleted the check-files branch June 9, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macos Specific to macOS operating system type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Old agent installation" error is not always triggered when expected
3 participants