Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the listing of the boards #668

Merged
merged 4 commits into from
Jan 24, 2022
Merged

fix the listing of the boards #668

merged 4 commits into from
Jan 24, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Oct 11, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

buf fix (closes #667)

  • What is the current behavior?

see #667

  • What is the new behavior?
  • Does this PR introduce a breaking change?

no

  • Other information:

@umbynos umbynos added the bug label Oct 11, 2021
@umbynos umbynos self-assigned this Oct 11, 2021
@per1234 per1234 added type: imperfection Perceived defect in any part of project and removed bug labels Oct 20, 2021
@umbynos
Copy link
Contributor Author

umbynos commented Jan 24, 2022

@pirropirro approved this

@umbynos umbynos merged commit e73b4bb into main Jan 24, 2022
@umbynos umbynos deleted the umbynos/list_bug branch January 24, 2022 16:10
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix the listing of the boards (#668)
73653fd 
* add sync mechanism for discovered ports and optimize a bit the code

* fix CI and make go-staticcheck happy

* remove unused function

* add mutex also to sh global var
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix go vet failing, followup of #668
ed637ed
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix go vet failing, followup of #668 (#693)
75b42b9
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix go vet failing, followup of #668 (#693)
80fc3e2
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix (again) go vet failing, followup of #668 and #693
b3c91fc
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix (again) go vet failing, followup of #668 and #693
dbfbb1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees

@umbynos umbynos

Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The agent does not list correctly the boards in the getting started
3 participants
@umbynos @cmaglie @per1234