Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhooks #1836

Open
Tracked by #28
dvsrepo opened this issue Mar 2, 2022 · 1 comment · May be fixed by #5467
Open
Tracked by #28

Webhooks #1836

dvsrepo opened this issue Mar 2, 2022 · 1 comment · May be fixed by #5467
Assignees
@jfcalvo
Milestone
v2.5.0

Comments

@dvsrepo
Copy link
Member

dvsrepo commented Mar 2, 2022 •
edited
Loading

As a user I want to have the ability to register webhooks so I can trigger certain actions when specific events happen.

One could have triggers for at least:

  1. Workspace events
  2. Dataset events

Dataset events would add the most value for automation
@dvsrepo dvsrepo added area: server Indicates that an issue or pull request is related to the server client labels Mar 2, 2022
@frascuchon frascuchon removed client area: server Indicates that an issue or pull request is related to the server labels Jul 12, 2022
@frascuchon frascuchon transferred this issue from another repository Nov 7, 2022
@frascuchon frascuchon added this to the 2023 Q4 milestone Nov 11, 2022
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the status: stale Indicates that there is no activity on an issue or pull request label Dec 28, 2022
@frascuchon frascuchon removed the status: stale Indicates that there is no activity on an issue or pull request label Jan 9, 2023
@nataliaElv nataliaElv removed this from the 2023 Q4 milestone Jul 4, 2023
@nataliaElv nataliaElv removed the Cloud label Nov 23, 2023
@nataliaElv nataliaElv mentioned this issue Feb 22, 2024
Open
@jfcalvo jfcalvo linked a pull request Sep 9, 2024 that will close this issue
Open
1 task
@jfcalvo jfcalvo self-assigned this Sep 10, 2024
@jfcalvo jfcalvo modified the milestones: v2.2.0, v2.3.0 Sep 10, 2024
This was referenced Sep 16, 2024
Merged
Merged
jfcalvo added a commit that referenced this issue Sep 16, 2024
@jfcalvo
chore: move webhooks folder outside api folder (#5493)
3fb3d66 
# Description

As discussed this PR is moving `webhooks` folder outside `api` folder.
Now that we have specific schemas for webhooks it does not have much
sense to have this code inside the `api` folder.

Refs #1836 

**Type of change**

- Refactor (change restructuring the codebase without changing
functionality)

**How Has This Been Tested**

- [x] Running test suite.

**Checklist**

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
jfcalvo added a commit that referenced this issue Sep 16, 2024
@jfcalvo
feat: remove response.upserted webhook event (#5494)
cbf28c7 
# Description

As discussed we want to stop using `response.upserted` webhook event and
instead use `response.created` or `response.updated` when a response is
upserted.

Refs #1836 

**Type of change**

- New feature (non-breaking change which adds functionality)

**How Has This Been Tested**

- [x] Running test suite.

**Checklist**

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
@jfcalvo jfcalvo mentioned this issue Sep 19, 2024
Merged
1 task
jfcalvo added a commit that referenced this issue Sep 20, 2024
@jfcalvo
[IMPROVEMENT] Add Webhooks delete events with expanded schemas (#5519)
6cd08fe 
# Description

Added some changes so we can generate Webhook events before deleting
resources and notify those events only after the resource has been
successfully deleted.

Affected events:
* Delete a dataset.
* Delete a response.
* Delete a record.
* Delete many records.

Refs #1836 

**Type of change**

- Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

- [x] Manually test that deleted resource events are correctly working.

**Checklist**

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
@jfcalvo jfcalvo mentioned this issue Sep 25, 2024
Merged
1 task
jfcalvo added a commit that referenced this issue Sep 25, 2024
@jfcalvo
feat: add missing tests for webhooks feature (#5537)
d8d2986 
# Description

This PR adds some missing tests checking that webhook events are
enqueued on background jobs when actions occurs inside Argilla app.

Refs #1836 

**Type of change**

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Refactor (change restructuring the codebase without changing
functionality)
- Improvement (change adding some improvement to an existing
functionality)
- Documentation update

**How Has This Been Tested**

 - [x] All tests should be passing.

**Checklist**

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
@jfcalvo jfcalvo mentioned this issue Sep 26, 2024
Merged
1 task
jfcalvo added a commit that referenced this issue Sep 26, 2024
@jfcalvo
feat: increase webhook requests timeout from 5 to 20 seconds (#5544)
922c59c 
# Description

This PR increases the timeout for webhook requests from `5` seconds to
`20` seconds so the webhook listeners have more time to generate a
response.

Refs #1836 

**Type of change**

- Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

- [x] Test suite should be passing.

**Checklist**

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
@frascuchon frascuchon modified the milestones: v2.3.0, v2.4.0 Sep 27, 2024
@nataliaElv nataliaElv modified the milestones: v2.4.0, v2.5.0 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfcalvo jfcalvo

Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

[FEATURE] Add Webhooks argilla-io/argilla
4 participants
@jfcalvo @dvsrepo @frascuchon @nataliaElv