Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move webhooks folder outside api folder #5493

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Sep 16, 2024

Description

As discussed this PR is moving webhooks folder outside api folder. Now that we have specific schemas for webhooks it does not have much sense to have this code inside the api folder.

Refs #1836

Type of change

  • Refactor (change restructuring the codebase without changing functionality)

How Has This Been Tested

  • Running test suite.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo changed the base branch from develop to feat/add-webhooks-feature-branch September 16, 2024 12:28
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (48a0dfe) to head (6d9c6da).
Report is 1 commits behind head on feat/add-webhooks-feature-branch.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feat/add-webhooks-feature-branch    #5493      +/-   ##
====================================================================
- Coverage                             91.42%   91.40%   -0.02%     
====================================================================
  Files                                   157      157              
  Lines                                  6321     6321              
====================================================================
- Hits                                   5779     5778       -1     
- Misses                                  542      543       +1     
Flag Coverage Δ
argilla-server 91.40% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit 3fb3d66 into feat/add-webhooks-feature-branch Sep 16, 2024
12 checks passed
@jfcalvo jfcalvo deleted the chore/move-webhooks-outside-api-folder branch September 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants