Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create delete dataset component #2370

Closed
2 tasks done
Tracked by #2003
, #2442
...
keithCuniah opened this issue Feb 20, 2023 · 0 comments · Fixed by #2442
Closed
2 tasks done
Tracked by #2003
, #2442
...

create delete dataset component #2370

keithCuniah opened this issue Feb 20, 2023 · 0 comments · Fixed by #2442
Assignees
@leiyre
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI)
Milestone
v1.5.0

Comments

@keithCuniah
Copy link
Contributor

keithCuniah commented Feb 20, 2023 •
edited
Loading

Untitled

ATTD :

  • if click on delete dataset button ⇒ fired the delete event
  • if click on delete dataset button ⇒ fired change page function
@keithCuniah keithCuniah mentioned this issue Feb 20, 2023
Closed
6 tasks
@tomaarsen tomaarsen added the area: ui Indicates that an issue or pull request is related to the User Interface (UI) label Feb 21, 2023
@leiyre leiyre mentioned this issue Feb 27, 2023
Merged
8 tasks
@leiyre leiyre added this to the v1.4.0 milestone Feb 28, 2023
@keithCuniah keithCuniah mentioned this issue Feb 28, 2023
Merged
22 tasks
leiyre added a commit that referenced this issue Mar 1, 2023
@leiyre
feat: create Dataset delete component (#2430)
58ec72a 
# Description

This PR includes new base-card component and dataset-delete component to
allow delete dataset from settings and remove the old logic from de
dataset list

Closes #2370

**Type of change**

- [x] New feature (non-breaking change which adds functionality)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [x] Test for BaseCard component
- [x] test for DatasetDeleteComponent

**Checklist**

- [x] I have merged the original branch into my forked branch
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
@frascuchon frascuchon modified the milestones: v1.4.0, v1.5.0 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI)
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

feat: Specific view for Dataset settings argilla-io/argilla
4 participants
@frascuchon @leiyre @tomaarsen @keithCuniah