Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create edition label component #2371

Closed
1 of 5 tasks
Tracked by #2003
, #2442
...
keithCuniah opened this issue Feb 20, 2023 · 0 comments · Fixed by #2422 or #2442
Closed
1 of 5 tasks
Tracked by #2003
, #2442
...

create edition label component #2371

keithCuniah opened this issue Feb 20, 2023 · 0 comments · Fixed by #2422 or #2442
Assignees
@leiyre @keithCuniah
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests

Comments

@keithCuniah
Copy link
Contributor

keithCuniah commented Feb 20, 2023 •
edited
Loading

(Drawing to define)

ATDD:

  • load previous labels and render the labels
  • add label to the list of labels
  • labels which are already saved have a delete button ⇒ remove label add by the user (which are not saved)
  • label which are not saved doesn’t have a delete button ⇒ can’t remove label already save
  • confirmation to save label
@keithCuniah keithCuniah mentioned this issue Feb 20, 2023
Closed
6 tasks
@keithCuniah keithCuniah added type: enhancement Indicates new feature requests area: ui Indicates that an issue or pull request is related to the User Interface (UI) labels Feb 20, 2023
@keithCuniah keithCuniah mentioned this issue Feb 27, 2023
Merged
15 tasks
keithCuniah added a commit that referenced this issue Feb 28, 2023
@keithCuniah
feat: create edition label component (#2422)
c08f9af 
# Description
Edition label component

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

To merge after #2210 

Closes #2371 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [x] Token classification
- [x] Text classification
- N/A Text2Text 

**Checklist**

- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works

---------

Co-authored-by: keithCuniah <[email protected]>
@keithCuniah keithCuniah mentioned this issue Feb 28, 2023
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@keithCuniah keithCuniah

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
2 participants
@leiyre @keithCuniah