Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add workspace add user command python -m argilla workspaces add-user #3680

Closed
Tracked by #3579
gabrielmbmb opened this issue Aug 31, 2023 · 1 comment · Fixed by #3712
Closed
Tracked by #3579

[FEATURE] Add workspace add user command python -m argilla workspaces add-user #3680

gabrielmbmb opened this issue Aug 31, 2023 · 1 comment · Fixed by #3712
Assignees
@eshwarhs
Labels
area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI) good first issue Indicates a good issue for first-time contributors type: enhancement Indicates new feature requests
Milestone
v1.16.0

Comments

@gabrielmbmb
Copy link
Member

gabrielmbmb commented Aug 31, 2023 •
edited
Loading

Add a new command that will allow to add an existing user to an existing workspace. To do so, create a new Typer command in src/argilla/tasks/workspaces and use argilla.client.workspaces.Workspace class and its method add_user.

python -m argilla workspaces --name my-workspace add-user user_name
@gabrielmbmb gabrielmbmb mentioned this issue Aug 31, 2023
Closed
@gabrielmbmb gabrielmbmb added type: enhancement Indicates new feature requests good first issue Indicates a good issue for first-time contributors area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI) labels Aug 31, 2023
@eshwarhs
Copy link
Contributor

eshwarhs commented Sep 4, 2023

@gabrielmbmb Can I take this up?

@gabrielmbmb gabrielmbmb added this to the v1.16.0 milestone Sep 4, 2023
@eshwarhs eshwarhs mentioned this issue Sep 5, 2023
Merged
15 tasks
gabrielmbmb added a commit that referenced this issue Sep 6, 2023
@eshwarhs @pre-commit-ci @gabrielmbmb
feat: add workspace add-user command (#3712)
9408193 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

This PR adds a new CLI command python -m argilla workspaces create.

Closes #3680

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [x] New feature (non-breaking change which adds functionality)

**How Has This Been Tested**

Unit tests have been added to tests/unit/tasks/workspaces directory

 - [x] Add user to workspace
 - [x] Add user to non-existent workspace
 - [x] Add non-existent user to workspace
 - [x] Add user belonging to same workspace
 - [x] Add user to workspace without specifying workspace name
 - [x]  Add user to workspace without logging in

**Checklist**

- [ ] I added relevant documentation
- [x] I followed the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [x] I have added relevant notes to the `CHANGELOG.md` file (See
https://keepachangelog.com/)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: gabrielmbmb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eshwarhs eshwarhs

Labels
area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI) good first issue Indicates a good issue for first-time contributors type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging a pull request may close this issue.

feat: add workspace add-user command eshwarhs/argilla
2 participants
@gabrielmbmb @eshwarhs