Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace add-user command #3712

Merged

Conversation

eshwarhs
Copy link
Contributor

@eshwarhs eshwarhs commented Sep 5, 2023

Description

This PR adds a new CLI command python -m argilla workspaces create.

Closes #3680

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Unit tests have been added to tests/unit/tasks/workspaces directory

  • Add user to workspace
  • Add user to non-existent workspace
  • Add non-existent user to workspace
  • Add user belonging to same workspace
  • Add user to workspace without specifying workspace name
  • Add user to workspace without logging in

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/argilla/tasks/workspaces/__main__.py 100.00%
src/argilla/tasks/workspaces/add_user.py 100.00%

📢 Thoughts on this report? Let us know!.

@gabrielmbmb gabrielmbmb self-requested a review September 6, 2023 07:02
@gabrielmbmb gabrielmbmb added type: enhancement Indicates new feature requests area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI) labels Sep 6, 2023
@gabrielmbmb gabrielmbmb added this to the v1.16.0 milestone Sep 6, 2023
@gabrielmbmb gabrielmbmb changed the title Feature/cli workspace add-user feat: add workspace add-user command Sep 6, 2023
Copy link
Member

@gabrielmbmb gabrielmbmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eshwarhs, thanks for the PR! Just one comment :)

src/argilla/tasks/workspaces/add_user.py Show resolved Hide resolved
@gabrielmbmb gabrielmbmb merged commit 9408193 into argilla-io:develop Sep 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI) type: enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add workspace add user command python -m argilla workspaces add-user
2 participants