Add metadata_filters support in filter_by from the Python client
#3835
Comments
13 tasks
13 tasks
frascuchon
added a commit
that referenced
this issue
Sep 28, 2023
# Description This PR adds the `pydantic.BaseModel` schemas for the `MetadataFilters` i.e. `TermsMetadataFilter`, `IntegerMetadataFilter`, and `FloatMetadataFilter` and also adds the arg `metadata_filters` to the `filter_by` method in the `RemoteFeedbackDataset` to be able to filter based on the pre-defined conditions for those metadata properties defined in the `FeedbackDataset` in Argilla. Closes #3835 **Type of change** - [X] New feature (non-breaking change which adds functionality) - [X] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** - [x] Add unit tests for `TermsMetadataFilter`, `IntegerMetadataFilter`, and `FloatMetadataFilter` - [ ] Add integration tests for the `filter_by` method with arg `metadata_filters` -> On hold because Elastic Search indexing is not working fine when triggering the tests - [ ] Add integration tests for the `get_records` function in the SDK with the arg `metadata_filters` -> On hold because Elastic Search indexing is not working fine when triggering the tests **Checklist** - [ ] I added relevant documentation - [X] follows the style guidelines of this project - [X] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [X] My changes generate no new warnings - [X] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Gabriel Martín Blázquez <[email protected]> Co-authored-by: Francisco Aranda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As of the recent development of the
metadata_propertiesandmetadata_filtersin the API, we should ensure that those are covered in the Python client too.The
metadata_propertieswere already covered at #3818 by @gabrielmbmb, but themetadata_filterswere still pending, so this issue is to add those into thefilter_bymethod ofRemoteFeedbackDatasetdatasets i.e.FeedbackDatasetdatasets pushed to Argilla.The text was updated successfully, but these errors were encountered: