Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metadata properties to Python client #3818

Merged
merged 19 commits into from
Sep 26, 2023
Merged

feat: add metadata properties to Python client #3818

merged 19 commits into from
Sep 26, 2023

Conversation

gabrielmbmb
Copy link
Member

@gabrielmbmb gabrielmbmb commented Sep 25, 2023 •
edited
Loading

Description

This PR adds the logic required to create metadata properties for a FeedbackDataset from the Python client. Also, it adds the logic needed to retrieve and parse the metadata properties back using FeedbackDataset.from_argilla and FeedbackDataset.push_to_argilla methods.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@gabrielmbmb gabrielmbmb added type: enhancement Indicates new feature requests client labels Sep 25, 2023
@gabrielmbmb gabrielmbmb added this to the v1.17.0 milestone Sep 25, 2023
@gabrielmbmb gabrielmbmb self-assigned this Sep 25, 2023
@gabrielmbmb gabrielmbmb force-pushed the feature/create-and-list-metadata-properties-from-python-client branch from ca4ff1a to 2d1702b Compare September 25, 2023 13:56
@gabrielmbmb gabrielmbmb force-pushed the feature/create-and-list-metadata-properties-from-python-client branch from a0410ac to 4f3e95b Compare September 25, 2023 14:53
@gabrielmbmb gabrielmbmb force-pushed the feature/create-and-list-metadata-properties-from-python-client branch from 64ada2b to 0c55772 Compare September 25, 2023 15:36
@gabrielmbmb gabrielmbmb marked this pull request as ready for review September 26, 2023 10:44
alvarobartt
alvarobartt approved these changes Sep 26, 2023
View reviewed changes
src/argilla/feedback/__init__.py Outdated Show resolved Hide resolved
src/argilla/client/feedback/dataset/base.py Outdated Show resolved Hide resolved
src/argilla/client/feedback/schemas/remote/metadata.py Outdated Show resolved Hide resolved
@gabrielmbmb gabrielmbmb mentioned this pull request Sep 26, 2023
Merged
13 tasks
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3818-ki24f765kq-no.a.run.app

@gabrielmbmb gabrielmbmb force-pushed the feature/create-and-list-metadata-properties-from-python-client branch from 2e5af32 to 44f2150 Compare September 26, 2023 12:54
@gabrielmbmb gabrielmbmb merged commit 975f791 into feature/support-for-metadata-filtering-and-sorting Sep 26, 2023
10 of 11 checks passed
@gabrielmbmb gabrielmbmb deleted the feature/create-and-list-metadata-properties-from-python-client branch September 26, 2023 13:35
This was referenced Sep 27, 2023
Closed
Closed
@frascuchon frascuchon modified the milestones: v1.17.0, v1.18.0 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarobartt alvarobartt alvarobartt approved these changes

@frascuchon frascuchon frascuchon approved these changes

Assignees

@gabrielmbmb gabrielmbmb

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmbmb @frascuchon @alvarobartt