Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to solve the error of integration tests in CI #4314

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Nov 23, 2023

Description

New update to try solving the error persistent in the integration tests on github actions.
The test has been split to see if that doesn't trigger the error, and the timeout has been set at the job level instead of a step.

Related to #4307

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 23, 2023
@dosubot dosubot bot added area: ci Indicates that an issue or pull request is related to the Continuous Integration (CI) language: python Pull requests or issues that update Python code team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior labels Nov 23, 2023
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4314-ki24f765kq-no.a.run.app

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6630d7b) 90.13% compared to head (42fd494) 64.75%.
Report is 487 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4314       +/-   ##
============================================
- Coverage    90.13%   64.75%   -25.39%     
============================================
  Files          233      321       +88     
  Lines        12493    18509     +6016     
============================================
+ Hits         11261    11986      +725     
- Misses        1232     6523     +5291     
Flag Coverage Δ
pytest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ce as it's not tested for the older trainers
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 26, 2023
@davidberenstein1957 davidberenstein1957 merged commit 658823a into develop Nov 26, 2023
14 of 16 checks passed
@davidberenstein1957 davidberenstein1957 deleted the fix/error-integration-tests branch November 26, 2023 13:49
leiyre pushed a commit that referenced this pull request Nov 29, 2023
* develop: (30 commits)
  chore: increase dev version release to 1.21.0
  fix: responses and suggestions filter QA (#4337)
  feat: delete suggestion from record on search engine (#4336)
  feat: update suggestion from record on search engine (#4339)
  bug: fix bug and update test (#4341)
  fix: preserve `TextClassificationSettings.label_schema` order (#4332)
  Update issue templates
  feat: 🚀 support for filtering and sorting by responses and suggestions (#4160)
  fix: handling errors for non-existing endpoints (#4325)
  feat: adding utils module and functions (#4121)
  Update labels in github workflows (#4315)
  fix: correct unification implementation for `RankingQuestionStrategy` (#4295)
  fix: update to solve the error of integration tests in CI (#4314)
  docs: revisit install process (#4261)
  feat: increase timeout minutes for python tests (#4307)
  docs: docs export dataset does not apply coloring for code snippets (#4296)
  docs: update final section of the rag haystack blog post (#4294)
  feat: add multi_modal templates and update vector setting (#4283)
  feat: better logging bar for FeedbackDataset (#4267)
  refactor: ArgillaTrainer for unified variable usage (#4214)
  ...

# Conflicts:
#	frontend/v1/infrastructure/repositories/RecordRepository.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci Indicates that an issue or pull request is related to the Continuous Integration (CI) language: python Pull requests or issues that update Python code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants