-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to solve the error of integration tests in CI #4314
Conversation
… it helps the problems in the CI
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4314-ki24f765kq-no.a.run.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4314 +/- ##
============================================
- Coverage 90.13% 64.75% -25.39%
============================================
Files 233 321 +88
Lines 12493 18509 +6016
============================================
+ Hits 11261 11986 +725
- Misses 1232 6523 +5291
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ce as it's not tested for the older trainers
* develop: (30 commits) chore: increase dev version release to 1.21.0 fix: responses and suggestions filter QA (#4337) feat: delete suggestion from record on search engine (#4336) feat: update suggestion from record on search engine (#4339) bug: fix bug and update test (#4341) fix: preserve `TextClassificationSettings.label_schema` order (#4332) Update issue templates feat: 🚀 support for filtering and sorting by responses and suggestions (#4160) fix: handling errors for non-existing endpoints (#4325) feat: adding utils module and functions (#4121) Update labels in github workflows (#4315) fix: correct unification implementation for `RankingQuestionStrategy` (#4295) fix: update to solve the error of integration tests in CI (#4314) docs: revisit install process (#4261) feat: increase timeout minutes for python tests (#4307) docs: docs export dataset does not apply coloring for code snippets (#4296) docs: update final section of the rag haystack blog post (#4294) feat: add multi_modal templates and update vector setting (#4283) feat: better logging bar for FeedbackDataset (#4267) refactor: ArgillaTrainer for unified variable usage (#4214) ... # Conflicts: # frontend/v1/infrastructure/repositories/RecordRepository.ts
Description
New update to try solving the error persistent in the integration tests on github actions.
The test has been split to see if that doesn't trigger the error, and the timeout has been set at the job level instead of a step.
Related to #4307
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)