Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responses and suggestions filter QA #4337

Merged
merged 8 commits into from
Nov 29, 2023

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Nov 28, 2023

This PR includes some fixes for responses and suggestions filter

  • Records queue fix
  • Color for suggestions in form
  • Minor changes for label selector
  • Overlayed copy button
  • Fix agent filter for suggestion url params

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code team: frontend Indicates that the issue or pull request is owned by the frontend team type: bug Indicates an unexpected problem or unintended behavior labels Nov 28, 2023
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4337-ki24f765kq-no.a.run.app

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 28, 2023
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 28, 2023
@leiyre leiyre merged commit 98b3f3a into develop Nov 29, 2023
13 checks passed
@leiyre leiyre deleted the fix/responses-and-suggestions-filter-qa branch November 29, 2023 09:14
davidberenstein1957 pushed a commit that referenced this pull request Nov 29, 2023
This PR includes some fixes for responses and suggestions filter

- [x] Records queue fix
- [x] Color for suggestions in form
- [x] Minor changes for label selector
- [x] Overlayed copy button

---------

Co-authored-by: Damián Pumar <[email protected]>
leiyre pushed a commit that referenced this pull request Nov 29, 2023
* develop: (30 commits)
  chore: increase dev version release to 1.21.0
  fix: responses and suggestions filter QA (#4337)
  feat: delete suggestion from record on search engine (#4336)
  feat: update suggestion from record on search engine (#4339)
  bug: fix bug and update test (#4341)
  fix: preserve `TextClassificationSettings.label_schema` order (#4332)
  Update issue templates
  feat: 🚀 support for filtering and sorting by responses and suggestions (#4160)
  fix: handling errors for non-existing endpoints (#4325)
  feat: adding utils module and functions (#4121)
  Update labels in github workflows (#4315)
  fix: correct unification implementation for `RankingQuestionStrategy` (#4295)
  fix: update to solve the error of integration tests in CI (#4314)
  docs: revisit install process (#4261)
  feat: increase timeout minutes for python tests (#4307)
  docs: docs export dataset does not apply coloring for code snippets (#4296)
  docs: update final section of the rag haystack blog post (#4294)
  feat: add multi_modal templates and update vector setting (#4283)
  feat: better logging bar for FeedbackDataset (#4267)
  refactor: ArgillaTrainer for unified variable usage (#4214)
  ...

# Conflicts:
#	frontend/v1/infrastructure/repositories/RecordRepository.ts
leiyre pushed a commit that referenced this pull request Dec 5, 2023
* develop: (41 commits)
  chore: update dev version
  chore: update CHANGELOG.md before release v1.20.0 (#4357)
  docs: temporal update to indicate persistent storage (#4355)
  docs: add suggestions and responses filters and sorting (#4345)
  docs: add end2end example on creating a basic text-classification dataset (#4208)
  Fix/responses suggestions filter fine tune (#4356)
  Fix/responses suggestions filter fine tune (#4356)
  fix: Accept draft responses on dataset records creation (#4354)
  Feature/responses operator (#4352)
  Feature/responses operator (#4352)
  chore: increase dev version release to 1.21.0
  chore: remove dev suffix for release branch
  fix: responses and suggestions filter QA (#4337)
  feat: delete suggestion from record on search engine (#4336)
  feat: update suggestion from record on search engine (#4339)
  bug: fix bug and update test (#4341)
  fix: preserve `TextClassificationSettings.label_schema` order (#4332)
  Update issue templates
  feat: 🚀 support for filtering and sorting by responses and suggestions (#4160)
  fix: handling errors for non-existing endpoints (#4325)
  ...

# Conflicts:
#	frontend/v1/domain/entities/question/Question.ts
#	frontend/v1/domain/entities/record/Record.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code size:L This PR changes 100-499 lines, ignoring generated files. team: frontend Indicates that the issue or pull request is owned by the frontend team type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants