Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token Classification epochs parameter trainer changed #4393

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Token Classification epochs parameter trainer changed #4393

merged 1 commit into from
Dec 11, 2023

Conversation

ignacioct
Copy link
Contributor

Closes #4373

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

This feature was tested while working on the SpanMarker tutorial, as I realised the number of training epochs only changed with trainer.update_config(num_train_epochs=2), not with trainer.update_config(max_epochs=2)

@ignacioct ignacioct self-assigned this Dec 11, 2023
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area: trainer Indicates that an issue or pull request is related to the Argilla Trainer team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team type: documentation Improvements or additions to documentation labels Dec 11, 2023
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2023
@davidberenstein1957 davidberenstein1957 merged commit cfff96b into main Dec 11, 2023
17 checks passed
@davidberenstein1957 davidberenstein1957 deleted the docs/epochs_parameter_trainer_changed branch December 11, 2023 11:38
leiyre pushed a commit that referenced this pull request Dec 12, 2023
Merge branch 'develop' into feature/prepare-bulk-annotation
ef50946 
* develop: (21 commits)
  ✨ Fix error handling in axios plugin for 401 (#4362)
  docs: Change `telemetry` section in tutorials to directly executable cells (#4399)
  docs: add faq files (#4363)
  fix: pinning `pytest-asyncio` to version `0.21.1` to avoid problems running unit tests on GitHub workflows (#4395)
  docs: add making most of markdown to tutorial page (#4376)
  Fixing typo in Fine Tuning LLMs Practical Guides (#4392)
  Token Classification epochs parameter trainer changed (#4393)
  docs: align practical guidescreate datasethtml with end2end examples structure (#4375)
  docs: hugging face space url (#4379)
  docs: extend using proxy section (#4368)
  chore: update dev version
  chore: update CHANGELOG.md before release v1.20.0 (#4357)
  docs: temporal update to indicate persistent storage (#4355)
  docs: add suggestions and responses filters and sorting (#4345)
  docs: add end2end example on creating a basic text-classification dataset (#4208)
  Fix/responses suggestions filter fine tune (#4356)
  Fix/responses suggestions filter fine tune (#4356)
  fix: Accept draft responses on dataset records creation (#4354)
  Feature/responses operator (#4352)
  Feature/responses operator (#4352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 davidberenstein1957 approved these changes

Assignees

@ignacioct ignacioct

Labels
area: trainer Indicates that an issue or pull request is related to the Argilla Trainer lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignacioct @davidberenstein1957