Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pinning pytest-asyncio to version 0.21.1 to avoid problems running unit tests on GitHub workflows #4395

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: pinning pytest-asyncio to version 0.21.1 to avoid problems running unit tests on GitHub workflows #4395

merged 1 commit into from
Dec 11, 2023

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Dec 11, 2023

Description

Looks like pytest-asyncio latest version (0.23.2) was causing some problems running unit tests returning multiple errors with the following message:

RuntimeError: There is no current event loop in thread 'MainThread'.

Pinning pytest-asyncio to version 0.21.1 is fixing these problems.

We should take a look to it in the future and update to a next version where these problems have been addressed.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Tests should be successfully executed for this PR.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area: ci Indicates that an issue or pull request is related to the Continuous Integration (CI) area: tests Indicates that an issue or pull request is related to the tests language: python Pull requests or issues that update Python code team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior type: dependencies Indicates a pull request that updates a dependency file labels Dec 11, 2023
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2023
@gabrielmbmb gabrielmbmb merged commit e033ad2 into develop Dec 11, 2023
14 checks passed
@gabrielmbmb gabrielmbmb deleted the fix/pytest-asyncio-latests-version-problems branch December 11, 2023 13:09
leiyre pushed a commit that referenced this pull request Dec 12, 2023
Merge branch 'develop' into feature/prepare-bulk-annotation
ef50946 
* develop: (21 commits)
  ✨ Fix error handling in axios plugin for 401 (#4362)
  docs: Change `telemetry` section in tutorials to directly executable cells (#4399)
  docs: add faq files (#4363)
  fix: pinning `pytest-asyncio` to version `0.21.1` to avoid problems running unit tests on GitHub workflows (#4395)
  docs: add making most of markdown to tutorial page (#4376)
  Fixing typo in Fine Tuning LLMs Practical Guides (#4392)
  Token Classification epochs parameter trainer changed (#4393)
  docs: align practical guidescreate datasethtml with end2end examples structure (#4375)
  docs: hugging face space url (#4379)
  docs: extend using proxy section (#4368)
  chore: update dev version
  chore: update CHANGELOG.md before release v1.20.0 (#4357)
  docs: temporal update to indicate persistent storage (#4355)
  docs: add suggestions and responses filters and sorting (#4345)
  docs: add end2end example on creating a basic text-classification dataset (#4208)
  Fix/responses suggestions filter fine tune (#4356)
  Fix/responses suggestions filter fine tune (#4356)
  fix: Accept draft responses on dataset records creation (#4354)
  Feature/responses operator (#4352)
  Feature/responses operator (#4352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmbmb gabrielmbmb gabrielmbmb approved these changes

@frascuchon frascuchon Awaiting requested review from frascuchon

Assignees
No one assigned
Labels
area: ci Indicates that an issue or pull request is related to the Continuous Integration (CI) area: tests Indicates that an issue or pull request is related to the tests language: python Pull requests or issues that update Python code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior type: dependencies Indicates a pull request that updates a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfcalvo @gabrielmbmb