Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History and Rollback : Don't display details of last deployed revision when opening the screen. #12183

Closed
lchastel opened this issue Jan 27, 2023 · 8 comments · Fixed by #16871
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@lchastel
Copy link

Summary

In History and Rollback, the details on last deployed revision are displayed.
I would like the last deployed revision to be displayed as a summary (like the other ones) when the window is opened.

The user could click on it to have the details.

Motivation

I would like to avoid to scroll to the bottom of the page to see previous deployed revisions.
It will be more readable.

Proposal

Display the last deployed version like the other ones.

I attached a screenshot of an application with 2 deployed devisions.
I would like the latest revision to be displayed has the second one.
01
02

@lchastel lchastel added the enhancement New feature or request label Jan 27, 2023
@saumeya saumeya added the component:ui User interfaces bugs and enhancements label Feb 1, 2023
@alexef
Copy link
Member

alexef commented Feb 5, 2023

We have the same issue that the expanded revision details takes too much screen space, making it hard to scroll and find a previous version to rollback.

However, every time this happens, the issue is that all parameters are displayed (not only the overrides).

May I suggest a different solution? Either collapse parameters by default and require an extra click to inspect them OR in Revision and History view show only overriden parameters. WDYT @saumeya ?

@saumeya
Copy link
Contributor

saumeya commented Feb 6, 2023

Just looked at the behavior, yes it makes sense to have a default collapsed section and a button to inspect the revision further (if we click on the Revision number it does expand it (however it opens a new tab to the commit)).
It would be better to have a separate button to collapse and expand all the details.
What are the overridden parameters @alexef, the image tag that was revised from the last revision? But it is maybe good to have all parameters visible

@alexef
Copy link
Member

alexef commented Feb 6, 2023

@saumeya in the first screenshot above, the two parameters prefixed with 🔨 are branch and env. All other parameters have the default value, and I wouldn't show them if possible.

@saumeya
Copy link
Contributor

saumeya commented Feb 7, 2023

Thanks @alexef , got it. That will be specifically for helm parameters. I am ok with olny showing the overridden parameters or helm could also have a collapsible section as well.

@tukak
Copy link
Contributor

tukak commented Nov 9, 2023

It would be great to see this implemented - we have helm applications with hundreds of parameters and finding the right revision to rollback to is very painful.

@jdomag
Copy link

jdomag commented Jan 24, 2024

Same here, I need to scroll for 2min to get to second revision.

@drileyst
Copy link

Yeah having the first revision collapsed would be a huge improvement.

@Tchoupinax
Copy link
Contributor

Hey,
I implemented a display button here. Give us your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants