-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a button to show parameter details (#12183) #16871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change. But could you please change how button is look. I think it is not super intuitive that it is a button
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Hello @pasha-codefresh I rebased and I used argocd default buttons style, tell me what you think! |
Signed-off-by: Tchoupinax <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the button looks, and I think the "Click to see source details" should be also a similar button, maybe "show/hide source details" and "show/hide parameter details" for the button you have already added.
I agree with the idea! Do you think it makes sense to do it in this PR? |
No, this can be done separately. LGTM! |
Hey! This change is a problem when you want to find a specific hash to rollback to. After the change just CMD+F to find the hash doesn't work anymore and we need to manually open all of the details and look for the hash. This is very suboptimal. From the code it looks like this behavior is not customizable, so right now we're either stuck with a soboptimal experience or rolling-back to previous ArgoCD release. |
Hello @marcin-wicha, |
Hello,
This work aims to not display parameter details by default in the history view. We might have hundreds of parameters and the original view to see old versions is not pratical due to the scroll. The issue is already opened here: #12183
Closes #12183
I would ask some feedback about the way to do it. Please find a record of the feature below.
Currently, the index in
rollback
query param is used to determine which history loads. That's said, with this new behavior the index won't be useful anymore: we load basics information for each history and display additional parameters details on demand.I'm asking if the design is good to load all metadata or if I add to continue to ask for a click before loading data. What do you think?
Edited overview
https://github.com/user-attachments/assets/a1fbe606-8334-4a24-b729-f866645300b8
Checklist: