Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable redis metrics exporter in HA deployment #16279

Open
peschmae opened this issue Nov 8, 2023 · 3 comments · May be fixed by #16283
Open

Enable redis metrics exporter in HA deployment #16279

peschmae opened this issue Nov 8, 2023 · 3 comments · May be fixed by #16283
Labels
enhancement New feature or request

Comments

@peschmae
Copy link
Contributor

peschmae commented Nov 8, 2023

Summary

Currently there are no exporter for redis metrics enabled.
To monitor redis, it's necessary to deploy an additional sidecar in each redis pod, which currently needs to be patched in.

Motivation

To monitor redis, a prometheus metrics exporter should be shipped by default.

Proposal

The helm chart used for redis-ha, supports enabling the oliver006/redis_exporter metrics exporter, with a simple flag.

@peschmae peschmae added the enhancement New feature or request label Nov 8, 2023
@peschmae
Copy link
Contributor Author

peschmae commented Nov 8, 2023

I'll be creating a pull request for this

peschmae added a commit to peschmae/argo-cd that referenced this issue Nov 8, 2023
@peschmae peschmae linked a pull request Nov 8, 2023 that will close this issue
13 tasks
peschmae added a commit to peschmae/argo-cd that referenced this issue Nov 24, 2023
peschmae added a commit to peschmae/argo-cd that referenced this issue Mar 18, 2024
Signed-off-by: Mathias Petermann <[email protected]>

Bump exporter to 1.58.0
@avinode-amagdy
Copy link

should this still be open? I think this is done already.

@peschmae
Copy link
Contributor Author

Just checked the HA manifests, and the redis metrics aren't exposed there: https://github.com/argoproj/argo-cd/blob/master/manifests/ha/base/redis-ha/chart/upstream.yaml

I'll rebase the pull request #16283 again.

peschmae added a commit to peschmae/argo-cd that referenced this issue Oct 31, 2024
Signed-off-by: Mathias Petermann <[email protected]>

Bump exporter to 1.58.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants