Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable redis metrics through helm Chart (#16279) #16283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peschmae
Copy link
Contributor

@peschmae peschmae commented Nov 8, 2023

This PR enables the redis metrics exporter through the HA helmchart

The values.yaml was adjusted and the manifests regenerated using the provided script.

Fixes #16279

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@peschmae peschmae requested a review from a team as a code owner November 8, 2023 11:55
@peschmae peschmae changed the title gitfeat: Enable redis metrics through helm Chart (#16279) feat: Enable redis metrics through helm Chart (#16279) Nov 8, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.16%. Comparing base (e861b55) to head (185bb36).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16283   +/-   ##
=======================================
  Coverage   55.16%   55.16%           
=======================================
  Files         324      324           
  Lines       55139    55139           
=======================================
+ Hits        30415    30420    +5     
+ Misses      22099    22095    -4     
+ Partials     2625     2624    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmpe
Copy link
Contributor

dmpe commented Dec 5, 2023

Thank you for contribution. I love to get this merged ...

@peschmae
Copy link
Contributor Author

Rebased branch to master, and bumped exporter versio to 1.58.0 (latest release as of 2024-03-18 )

I hope I can find someone at Kubecon to help me merge this PR, would be great to have less patches required for ArgoCD :)

Signed-off-by: Mathias Petermann <[email protected]>

Bump exporter to 1.58.0
@peschmae
Copy link
Contributor Author

Rebased branch to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable redis metrics exporter in HA deployment
2 participants