-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider avoiding CodeQL noise about password
/ secret
fields
#20094
Labels
Comments
14 tasks
crenshaw-dev
pushed a commit
that referenced
this issue
Sep 30, 2024
* chore(common): Split const from unrelated util/clusterauth const Signed-off-by: Josh Soref <[email protected]> * chore: Try to make CodeQL happy Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]>
moleus
pushed a commit
to moleus/argo-cd
that referenced
this issue
Oct 7, 2024
* chore(common): Split const from unrelated util/clusterauth const Signed-off-by: Josh Soref <[email protected]> * chore: Try to make CodeQL happy Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Moleus <[email protected]>
gdsoumya
pushed a commit
that referenced
this issue
Oct 7, 2024
…#20085) * docs: Add `404 Not Found` github notification error to troubleshooting docs Signed-off-by: Moleus <[email protected]> * Update docs/operator-manual/notifications/troubleshooting-errors.md Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * Update docs/operator-manual/notifications/troubleshooting-errors.md Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by upgrading path-to-regexp from 1.8.0 to 1.9.0 (#20087) Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps-dev): bump @types/node from 22.5.5 to 22.7.2 in /ui-test (#20112) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.5 to 22.7.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix(extension): add header to support apps-in-any-namespace (#20123) Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Moleus <[email protected]> * Fix typo (#20127) Remove a redundant "is". Signed-off-by: Symeon Meichanetzoglou <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(ui): add optional check to avoid undefined reference in project detail (#20044) Signed-off-by: linghaoSu <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump Helm from 3.15.2 to 3.15.4 (#20135) * sec: upgrade helm version in order to fix critical vulnerability Signed-off-by: pashakostohrys <[email protected]> * sec: upgrade helm version in order to fix critical vulnerability Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: oras-go client should fallback to docker config if no credentials specified (#18133) * oras-go client should fallback to docker config if no credentials specified Signed-off-by: Tony Au-Yeung <[email protected]> * Fix tests Signed-off-by: Tony Au-Yeung <[email protected]> * Fix lint Signed-off-by: Tony Au-Yeung <[email protected]> * gofumpt Signed-off-by: Tony Au-Yeung <[email protected]> * Validate auth header Signed-off-by: Tony Au-Yeung <[email protected]> --------- Signed-off-by: Tony Au-Yeung <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (#20154) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.7.0 to 6.8.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@5cd11c3...32945a3) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: Fix argocd appset generate failure due to missing clusterrole (#20162) * fix: FIx argocd-server clusterrole to allow argocd appset generate using cluster generator Signed-off-by: Pradithya Aria <[email protected]> * fix: update generated code Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Moleus <[email protected]> * [Bot] docs: Update Snyk reports (#20146) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: repo generate paths value in namespace install is incorrectly formatted (#20139) * Fix repo generate paths value in namespace install Signed-off-by: todaywasawesome <[email protected]> * Fix in base and regen Signed-off-by: todaywasawesome <[email protected]> --------- Signed-off-by: todaywasawesome <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: introduce pause/unpause actions for Numaplane CRDs (#20128) * feat: introduce pause/unpause actions for Numaplane CRDs Signed-off-by: Dillen Padhiar <[email protected]> * test: fixed incorrect file names Signed-off-by: Dillen Padhiar <[email protected]> * chore: codegen Signed-off-by: Dillen Padhiar <[email protected]> * fix: empty check for lifecycle Signed-off-by: Dillen Padhiar <[email protected]> * fix: nil check Signed-off-by: Dillen Padhiar <[email protected]> * fix: nil checks Signed-off-by: Dillen Padhiar <[email protected]> * test: testing different starting spec Signed-off-by: Dillen Padhiar <[email protected]> * feat: add nil checks for all possible nil fields Signed-off-by: Dillen Padhiar <[email protected]> * chore: rerun tests Signed-off-by: Dillen Padhiar <[email protected]> --------- Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Moleus <[email protected]> * feat(appset): Add a cache layer for Argo Projects to speed-up application validation (#18703) * feat(appset): Add a cache layer for Argo Projects to speed-up application validation Signed-off-by: Philippe Da Costa <[email protected]> * Use local client rather than custom cache Signed-off-by: Philippe Da Costa <[email protected]> * Clean go.mod Signed-off-by: Philippe Da Costa <[email protected]> * Merge master Signed-off-by: Philippe Da Costa <[email protected]> * Fix after merging master Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> * Initialize appProject variable inside loop Signed-off-by: Philippe Da Costa <[email protected]> * Remove unused ArgoAppClientset field Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> * Fix linter issue Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> --------- Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: added note re. arch of example application on getting_started.md (#20143) added warning that example application may not run on all archs Signed-off-by: Crumbs <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(ui): hide resource actions menu if it's empty (#20051) Signed-off-by: cef <[email protected]> Signed-off-by: Moleus <[email protected]> * Fixes minor typo which lead to using the bearer token as api URL and was obviously not working. (#20169) Signed-off-by: asjervanasten <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: Try to make CodeQL happy (#20094) (#20129) * chore(common): Split const from unrelated util/clusterauth const Signed-off-by: Josh Soref <[email protected]> * chore: Try to make CodeQL happy Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (#20174) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@32945a3...4f58ea7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(ui): make name property for repos (#20077) * name-option-added Signed-off-by: Surajyadav <[email protected]> * lint Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: basic e2e tests in order to verify notification service health (#20182) * feat: basic e2e tests in order to verify notification service health Signed-off-by: pashakostohrys <[email protected]> * feat: basic e2e tests in order to verify notification service health Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: document credentials server (#20078) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: Add nodeSelector for Linux nodes (#20148) * feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server Signed-off-by: leehosu <[email protected]> * refactor : Reversal the wrong part and correct it. Signed-off-by: leehosu <[email protected]> * Update argocd-application-controller-statefulset.yaml Signed-off-by: l2h <[email protected]> * feat: Add nodeSelector for Linux nodes in dex-server, argo-server Signed-off-by: leehosu <[email protected]> * refactor: update code to resolving for intergration test Signed-off-by: leehosu <[email protected]> * refactor: update code to resolving for codegen Signed-off-by: leehosu <[email protected]> * Run make manifests-local and then commit Signed-off-by: leehosu <[email protected]> --------- Signed-off-by: leehosu <[email protected]> Signed-off-by: l2h <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump github.com/cyphar/filepath-securejoin (#20173) Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.2 to 0.3.3. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md) - [Commits](cyphar/filepath-securejoin@v0.3.2...v0.3.3) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(appset): parameterize requeue time #20063 (#20064) Signed-off-by: Moleus <[email protected]> * chore(ci): better handling of Go and Node dependency bumps (#20168) * chore(ci): better handling of Go and Node dependency bumps Signed-off-by: Michael Crenshaw <[email protected]> temporarily remove condition Signed-off-by: Michael Crenshaw <[email protected]> quit early if there are no changes Signed-off-by: Michael Crenshaw <[email protected]> use latest checkout action and actually test version change Signed-off-by: Michael Crenshaw <[email protected]> use github token Signed-off-by: Michael Crenshaw <[email protected]> workflow for node Signed-off-by: Michael Crenshaw <[email protected]> clean up after changing node version Signed-off-by: Michael Crenshaw <[email protected]> revert temporary changes Signed-off-by: Michael Crenshaw <[email protected]> more docs Signed-off-by: Michael Crenshaw <[email protected]> * bump linter version Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump codecov/codecov-action from 4.5.0 to 4.6.0 (#20188) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@e28ff12...b9fd7d1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * docs(ui): sorting version (#20181) Signed-off-by: nueavv <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: add outpost24 to users.md (#20197) Signed-off-by: Phong Do <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: Update argocd path for command in notifification in troubleshooting docs (#20120) Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump google.golang.org/grpc from 1.67.0 to 1.67.1 (#20190) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.67.0 to 1.67.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.67.0...v1.67.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump chromedriver from 129.0.0 to 129.0.2 in /ui-test (#20189) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 129.0.0 to 129.0.2. - [Commits](giggio/node-chromedriver@129.0.0...129.0.2) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump bitnami/kubectl in /test/container (#20191) Bumps bitnami/kubectl from `da4a986` to `b509ab6`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump library/busybox in /test/e2e/multiarch-container (#20193) Bumps library/busybox from `c230832` to `768e5c6`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix(helm): escape consecutive commas in cleanSetParameters (#19269) (#20113) Signed-off-by: KangManJoo <[email protected]> Signed-off-by: daengdaengLee <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Signed-off-by: Moleus <[email protected]> * Update troubleshooting-errors.md (#20201) Fixing some phrasing and adding more clarity. Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Rework git tag semver resolution (#20083) (#20096) * Write initial tests Signed-off-by: Paul Larsen <[email protected]> * Improve git tag semver resolution Signed-off-by: Paul Larsen <[email protected]> * Add company to list of users Signed-off-by: Paul Larsen <[email protected]> * Fix broken error string check Signed-off-by: Paul Larsen <[email protected]> * Fix incorrect semver test assumption Signed-off-by: Paul Larsen <[email protected]> * switch to debug statement Signed-off-by: Paul Larsen <[email protected]> * Add more testcases for review Signed-off-by: Paul Larsen <[email protected]> * review comments Signed-off-by: Paul Larsen <[email protected]> --------- Signed-off-by: Paul Larsen <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (#20207) Signed-off-by: Moleus <[email protected]> * feat(ui): support auto theme (#20080) * feat(theme): support auto theme Signed-off-by: linghaoSu <[email protected]> * fix(ui): set default theme as light Signed-off-by: linghaoSu <[email protected]> * fix(ui): only register listener when theme is auto Signed-off-by: linghaoSu <[email protected]> --------- Signed-off-by: linghaoSu <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump selenium-webdriver from 4.24.1 to 4.25.0 in /ui-test (#20058) Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.24.1 to 4.25.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.25.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: refine deny destination checks (#20045) * fix: refine server deny check Fixes #19804. The deny destination check can be made more intuitive by doing the following: * short-circuit any deny destination * first, for any deny server destination, _also_ check if the namespace matches * for any deny namespace destination, reject as before Signed-off-by: Blake Pettersson <[email protected]> * fix: also assert that server matches on ns deny Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: Added unit tests and fix e2e tests for application sync decoupling feature (#19966) * fixed doc comments and added unit tests Signed-off-by: anandf <[email protected]> * Added comments for the newly added unit tests Signed-off-by: anandf <[email protected]> * Refactored method name to deriveServiceAccountToImpersonate Signed-off-by: anandf <[email protected]> * Using const name in return value Signed-off-by: anandf <[email protected]> * Added unit tests for argocd proj add-destination-service-accounts Signed-off-by: anandf <[email protected]> * Fixed failing e2e tests Signed-off-by: anandf <[email protected]> * Fix linting errors Signed-off-by: anandf <[email protected]> * Using require package instead of assert and fixed code generation Signed-off-by: anandf <[email protected]> * Removed parallel execution of tests for sync with impersonate Signed-off-by: anandf <[email protected]> * Added err checks for glob validations Signed-off-by: anandf <[email protected]> * Fixed e2e tests for sync impersonation Signed-off-by: anandf <[email protected]> * Using consistently based expects in E2E tests Signed-off-by: anandf <[email protected]> * Added more unit tests and fixed go generate Signed-off-by: anandf <[email protected]> * Fixed failed lint errors, unit and e2e test failures Signed-off-by: anandf <[email protected]> * Fixed goimports linter issue Signed-off-by: anandf <[email protected]> * Added code comments and added few missing unit tests Signed-off-by: anandf <[email protected]> * Added missing unit test for GetDestinationServiceAccounts method Signed-off-by: anandf <[email protected]> * Fixed goimports formatting with local for project_test.go Signed-off-by: anandf <[email protected]> * Corrected typo in a field name additionalObjs Signed-off-by: anandf <[email protected]> * Fixed failing unit tests Signed-off-by: anandf <[email protected]> --------- Signed-off-by: anandf <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Fix false positive in plugin application discovery (#20196) * fix: fix false positive in plugin application discovery Signed-off-by: Pradithya Aria <[email protected]> * fix: apply suggestion to return immediately if discovery is not configured for unnamed plugin Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: update health check to support modelmesh (#20142) Signed-off-by: Trevor Royer <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: rename protobuf field according to convention (#20221) Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: add TBC Bank to USERS.md (#20227) * docs: add TBC Bank to USERS.md Signed-off-by: Mate Gogiberidze <[email protected]> * docs: reorder TBC Bank by alphabetical Signed-off-by: Mate Gogiberidze <[email protected]> --------- Signed-off-by: Mate Gogiberidze <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/setup-buildx-action from 3.6.1 to 3.7.0 (#20224) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.6.1 to 3.7.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@988b5a0...8026d2b) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump tj-actions/changed-files from 45.0.2 to 45.0.3 (#20225) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45.0.2 to 45.0.3. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@48d8f15...c3a1bb2) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: use `ErrorContains(t, err` instead of `Contains(t, err.Error()` (#20220) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: Correct ApplicationSet (spec.preservedFields) (#20206) * Fix docs Signed-off-by: jyoungs <[email protected]> * Remove another errant block; improved comments Signed-off-by: jyoungs <[email protected]> * Actually removed the errant block Signed-off-by: jyoungs <[email protected]> * More doc fixes Signed-off-by: jyoungs <[email protected]> * More spec fixes + USERS Signed-off-by: jyoungs <[email protected]> --------- Signed-off-by: jyoungs <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(health): only consider non-empty health checks (#20232) * fix(health): only consider non-empty health checks For wildcard health checks, only consider wildcards with a non-empty health check. Fixes #16905 (at least partially). Signed-off-by: Blake Pettersson <[email protected]> * test: renaming test case for clarity Signed-off-by: Blake Pettersson <[email protected]> * refactor: add clarity as to what the function is supposed to do Signed-off-by: Blake Pettersson <[email protected]> * Update docs/operator-manual/health.md Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Blake Pettersson <[email protected]> * test: add test case for `*/*` override with empty healthcheck Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: support managing cluster with multiple argocd instances and annotation based tracking (#20222) Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Moleus <[email protected]> * fix notification-catlog issue (#20237) Signed-off-by: ajinkyak423 <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(ci): add renovate for golangci-lint, go and node version (#20236) Signed-off-by: ggjulio <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump actions/cache from 4.0.2 to 4.1.0 (#20240) Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.1.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0c45773...2cdf405) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/setup-buildx-action from 3.7.0 to 3.7.1 (#20241) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.7.0 to 3.7.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@8026d2b...c47758b) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/time from 0.6.0 to 0.7.0 (#20244) Bumps [golang.org/x/time](https://github.com/golang/time) from 0.6.0 to 0.7.0. - [Commits](golang/time@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(cli): Add app diff option to specify exit code when diff (#20144) The argocd app diff command returns 1 if a difference is found. In related issues, they want to return an error code that is distinguishable from common errors. However, changing the existing behavior is likely to break user's automation code. So we want to provide an explicit option(--diff-exit-code) to specify an error code. Related: #3588 Signed-off-by: Eugene Kim <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: add support for helm skipTests flag (#20118) Signed-off-by: jaehanbyun <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump sigstore/cosign-installer from 3.6.0 to 3.7.0 (#20242) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@4959ce0...dc72c7d) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/term from 0.24.0 to 0.25.0 (#20245) Bumps [golang.org/x/term](https://github.com/golang/term) from 0.24.0 to 0.25.0. - [Commits](golang/term@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/crypto from 0.27.0 to 0.28.0 (#20243) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0. - [Commits](golang/crypto@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/net from 0.29.0 to 0.30.0 (#20246) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.29.0 to 0.30.0. - [Commits](golang/net@v0.29.0...v0.30.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore: update notifications-engine to 22ccfe0caf45 (#20239) * Update notifications-engine Signed-off-by: SLASHLogin <[email protected]> * Update docs for Opsgenie notifications Signed-off-by: SLASHLogin <[email protected]> * docs: Fix outdated slack notification configuration readme Signed-off-by: SLASHLogin <[email protected]> --------- Signed-off-by: SLASHLogin <[email protected]> Signed-off-by: Moleus <[email protected]> * [Bot] docs: Update Snyk reports (#20250) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: handle incorrect cluster RESTconfig without panic (#20150) Signed-off-by: cef <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update node version (#20248) * chore(deps): update node version * Update ui/.nvmrc Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * sec: update alpine/helm to 3.16.1 (#20253) Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(ci): update renovate config (#20254) Signed-off-by: ggjulio <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Policy/policy.open-cluster-management.io health check is broken (#20108) (#20109) Tried using the health check as listed here but it gave error: | error setting app health: failed to get resource health for "Policy" with name "XXXX" in namespace "local-cluster": <string>:35: invalid value (nil) at index 1 in table for concat stack traceback: [G]: in function 'concat' <string>:35: in main chunk [G]: ? This change fixes the error by updating how the noncompliant clusters are tracked and counted to use latest Lua recommendations. Signed-off-by: Ian Tewksbury <[email protected]> Signed-off-by: Moleus <[email protected]> * feat(applicationset): Add FlatList option to cluster generator - Fixes #20212 (#20231) * (feat) - Add FlatList option to cluster generator Signed-off-by: OpenGuidou <[email protected]> * Update docs/operator-manual/applicationset/Generators-Cluster.md Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update docs dependencies (#20257) * chore(deps): update docs dependencies Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump rtd python version Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update group golang to v1.23.2 (#20256) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore: bump k8s versions in e2e tests (#19669) Signed-off-by: Moleus <[email protected]> --------- Signed-off-by: Moleus <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Symeon Meichanetzoglou <[email protected]> Signed-off-by: linghaoSu <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Tony Au-Yeung <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: CI <[email protected]> Signed-off-by: todaywasawesome <[email protected]> Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Crumbs <[email protected]> Signed-off-by: cef <[email protected]> Signed-off-by: asjervanasten <[email protected]> Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: leehosu <[email protected]> Signed-off-by: l2h <[email protected]> Signed-off-by: nueavv <[email protected]> Signed-off-by: Phong Do <[email protected]> Signed-off-by: KangManJoo <[email protected]> Signed-off-by: daengdaengLee <[email protected]> Signed-off-by: Paul Larsen <[email protected]> Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: anandf <[email protected]> Signed-off-by: Trevor Royer <[email protected]> Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Mate Gogiberidze <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: jyoungs <[email protected]> Signed-off-by: ajinkyak423 <[email protected]> Signed-off-by: ggjulio <[email protected]> Signed-off-by: Eugene Kim <[email protected]> Signed-off-by: jaehanbyun <[email protected]> Signed-off-by: SLASHLogin <[email protected]> Signed-off-by: Ian Tewksbury <[email protected]> Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dan Garfield <[email protected]> Co-authored-by: Cheng Fang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Symeon Meichanetzoglou <[email protected]> Co-authored-by: Linghao Su <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Tony Au-Yeung <[email protected]> Co-authored-by: aria <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: CI <[email protected]> Co-authored-by: Dillen Padhiar <[email protected]> Co-authored-by: Daco <[email protected]> Co-authored-by: Crumbs <[email protected]> Co-authored-by: ABBOUD Moncef <[email protected]> Co-authored-by: appiepollo14 <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Suraj yadav <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: l2h <[email protected]> Co-authored-by: rumstead <[email protected]> Co-authored-by: 1102 <[email protected]> Co-authored-by: Phong Do <[email protected]> Co-authored-by: Olivier Wenger <[email protected]> Co-authored-by: KangManJoo <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Co-authored-by: Paul Larsen <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> Co-authored-by: Anand Francis Joseph <[email protected]> Co-authored-by: Trevor Royer <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Mate Gogiberidze <[email protected]> Co-authored-by: Matthieu MOREL <[email protected]> Co-authored-by: Jeff Youngs <[email protected]> Co-authored-by: Ajinkya Ganesh Kumbhar <[email protected]> Co-authored-by: Julio <[email protected]> Co-authored-by: Eugene Kim <[email protected]> Co-authored-by: 변재한 <[email protected]> Co-authored-by: SLASHLogin <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ian Tewksbury <[email protected]> Co-authored-by: OpenGuidou <[email protected]>
ALIHAMZA99
pushed a commit
to ALIHAMZA99/argo-cd
that referenced
this issue
Oct 10, 2024
…argoproj#20085) * docs: Add `404 Not Found` github notification error to troubleshooting docs Signed-off-by: Moleus <[email protected]> * Update docs/operator-manual/notifications/troubleshooting-errors.md Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * Update docs/operator-manual/notifications/troubleshooting-errors.md Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by upgrading path-to-regexp from 1.8.0 to 1.9.0 (argoproj#20087) Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps-dev): bump @types/node from 22.5.5 to 22.7.2 in /ui-test (argoproj#20112) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.5 to 22.7.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix(extension): add header to support apps-in-any-namespace (argoproj#20123) Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Moleus <[email protected]> * Fix typo (argoproj#20127) Remove a redundant "is". Signed-off-by: Symeon Meichanetzoglou <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(ui): add optional check to avoid undefined reference in project detail (argoproj#20044) Signed-off-by: linghaoSu <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump Helm from 3.15.2 to 3.15.4 (argoproj#20135) * sec: upgrade helm version in order to fix critical vulnerability Signed-off-by: pashakostohrys <[email protected]> * sec: upgrade helm version in order to fix critical vulnerability Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: oras-go client should fallback to docker config if no credentials specified (argoproj#18133) * oras-go client should fallback to docker config if no credentials specified Signed-off-by: Tony Au-Yeung <[email protected]> * Fix tests Signed-off-by: Tony Au-Yeung <[email protected]> * Fix lint Signed-off-by: Tony Au-Yeung <[email protected]> * gofumpt Signed-off-by: Tony Au-Yeung <[email protected]> * Validate auth header Signed-off-by: Tony Au-Yeung <[email protected]> --------- Signed-off-by: Tony Au-Yeung <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (argoproj#20154) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.7.0 to 6.8.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@5cd11c3...32945a3) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: Fix argocd appset generate failure due to missing clusterrole (argoproj#20162) * fix: FIx argocd-server clusterrole to allow argocd appset generate using cluster generator Signed-off-by: Pradithya Aria <[email protected]> * fix: update generated code Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Moleus <[email protected]> * [Bot] docs: Update Snyk reports (argoproj#20146) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: repo generate paths value in namespace install is incorrectly formatted (argoproj#20139) * Fix repo generate paths value in namespace install Signed-off-by: todaywasawesome <[email protected]> * Fix in base and regen Signed-off-by: todaywasawesome <[email protected]> --------- Signed-off-by: todaywasawesome <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: introduce pause/unpause actions for Numaplane CRDs (argoproj#20128) * feat: introduce pause/unpause actions for Numaplane CRDs Signed-off-by: Dillen Padhiar <[email protected]> * test: fixed incorrect file names Signed-off-by: Dillen Padhiar <[email protected]> * chore: codegen Signed-off-by: Dillen Padhiar <[email protected]> * fix: empty check for lifecycle Signed-off-by: Dillen Padhiar <[email protected]> * fix: nil check Signed-off-by: Dillen Padhiar <[email protected]> * fix: nil checks Signed-off-by: Dillen Padhiar <[email protected]> * test: testing different starting spec Signed-off-by: Dillen Padhiar <[email protected]> * feat: add nil checks for all possible nil fields Signed-off-by: Dillen Padhiar <[email protected]> * chore: rerun tests Signed-off-by: Dillen Padhiar <[email protected]> --------- Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Moleus <[email protected]> * feat(appset): Add a cache layer for Argo Projects to speed-up application validation (argoproj#18703) * feat(appset): Add a cache layer for Argo Projects to speed-up application validation Signed-off-by: Philippe Da Costa <[email protected]> * Use local client rather than custom cache Signed-off-by: Philippe Da Costa <[email protected]> * Clean go.mod Signed-off-by: Philippe Da Costa <[email protected]> * Merge master Signed-off-by: Philippe Da Costa <[email protected]> * Fix after merging master Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> * Initialize appProject variable inside loop Signed-off-by: Philippe Da Costa <[email protected]> * Remove unused ArgoAppClientset field Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> * Fix linter issue Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> --------- Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: added note re. arch of example application on getting_started.md (argoproj#20143) added warning that example application may not run on all archs Signed-off-by: Crumbs <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(ui): hide resource actions menu if it's empty (argoproj#20051) Signed-off-by: cef <[email protected]> Signed-off-by: Moleus <[email protected]> * Fixes minor typo which lead to using the bearer token as api URL and was obviously not working. (argoproj#20169) Signed-off-by: asjervanasten <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: Try to make CodeQL happy (argoproj#20094) (argoproj#20129) * chore(common): Split const from unrelated util/clusterauth const Signed-off-by: Josh Soref <[email protected]> * chore: Try to make CodeQL happy Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (argoproj#20174) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@32945a3...4f58ea7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(ui): make name property for repos (argoproj#20077) * name-option-added Signed-off-by: Surajyadav <[email protected]> * lint Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: basic e2e tests in order to verify notification service health (argoproj#20182) * feat: basic e2e tests in order to verify notification service health Signed-off-by: pashakostohrys <[email protected]> * feat: basic e2e tests in order to verify notification service health Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: document credentials server (argoproj#20078) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: Add nodeSelector for Linux nodes (argoproj#20148) * feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server Signed-off-by: leehosu <[email protected]> * refactor : Reversal the wrong part and correct it. Signed-off-by: leehosu <[email protected]> * Update argocd-application-controller-statefulset.yaml Signed-off-by: l2h <[email protected]> * feat: Add nodeSelector for Linux nodes in dex-server, argo-server Signed-off-by: leehosu <[email protected]> * refactor: update code to resolving for intergration test Signed-off-by: leehosu <[email protected]> * refactor: update code to resolving for codegen Signed-off-by: leehosu <[email protected]> * Run make manifests-local and then commit Signed-off-by: leehosu <[email protected]> --------- Signed-off-by: leehosu <[email protected]> Signed-off-by: l2h <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump github.com/cyphar/filepath-securejoin (argoproj#20173) Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.2 to 0.3.3. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md) - [Commits](cyphar/filepath-securejoin@v0.3.2...v0.3.3) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(appset): parameterize requeue time argoproj#20063 (argoproj#20064) Signed-off-by: Moleus <[email protected]> * chore(ci): better handling of Go and Node dependency bumps (argoproj#20168) * chore(ci): better handling of Go and Node dependency bumps Signed-off-by: Michael Crenshaw <[email protected]> temporarily remove condition Signed-off-by: Michael Crenshaw <[email protected]> quit early if there are no changes Signed-off-by: Michael Crenshaw <[email protected]> use latest checkout action and actually test version change Signed-off-by: Michael Crenshaw <[email protected]> use github token Signed-off-by: Michael Crenshaw <[email protected]> workflow for node Signed-off-by: Michael Crenshaw <[email protected]> clean up after changing node version Signed-off-by: Michael Crenshaw <[email protected]> revert temporary changes Signed-off-by: Michael Crenshaw <[email protected]> more docs Signed-off-by: Michael Crenshaw <[email protected]> * bump linter version Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump codecov/codecov-action from 4.5.0 to 4.6.0 (argoproj#20188) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@e28ff12...b9fd7d1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * docs(ui): sorting version (argoproj#20181) Signed-off-by: nueavv <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: add outpost24 to users.md (argoproj#20197) Signed-off-by: Phong Do <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: Update argocd path for command in notifification in troubleshooting docs (argoproj#20120) Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump google.golang.org/grpc from 1.67.0 to 1.67.1 (argoproj#20190) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.67.0 to 1.67.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.67.0...v1.67.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump chromedriver from 129.0.0 to 129.0.2 in /ui-test (argoproj#20189) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 129.0.0 to 129.0.2. - [Commits](giggio/node-chromedriver@129.0.0...129.0.2) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump bitnami/kubectl in /test/container (argoproj#20191) Bumps bitnami/kubectl from `da4a986` to `b509ab6`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump library/busybox in /test/e2e/multiarch-container (argoproj#20193) Bumps library/busybox from `c230832` to `768e5c6`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix(helm): escape consecutive commas in cleanSetParameters (argoproj#19269) (argoproj#20113) Signed-off-by: KangManJoo <[email protected]> Signed-off-by: daengdaengLee <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Signed-off-by: Moleus <[email protected]> * Update troubleshooting-errors.md (argoproj#20201) Fixing some phrasing and adding more clarity. Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Rework git tag semver resolution (argoproj#20083) (argoproj#20096) * Write initial tests Signed-off-by: Paul Larsen <[email protected]> * Improve git tag semver resolution Signed-off-by: Paul Larsen <[email protected]> * Add company to list of users Signed-off-by: Paul Larsen <[email protected]> * Fix broken error string check Signed-off-by: Paul Larsen <[email protected]> * Fix incorrect semver test assumption Signed-off-by: Paul Larsen <[email protected]> * switch to debug statement Signed-off-by: Paul Larsen <[email protected]> * Add more testcases for review Signed-off-by: Paul Larsen <[email protected]> * review comments Signed-off-by: Paul Larsen <[email protected]> --------- Signed-off-by: Paul Larsen <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (argoproj#20207) Signed-off-by: Moleus <[email protected]> * feat(ui): support auto theme (argoproj#20080) * feat(theme): support auto theme Signed-off-by: linghaoSu <[email protected]> * fix(ui): set default theme as light Signed-off-by: linghaoSu <[email protected]> * fix(ui): only register listener when theme is auto Signed-off-by: linghaoSu <[email protected]> --------- Signed-off-by: linghaoSu <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump selenium-webdriver from 4.24.1 to 4.25.0 in /ui-test (argoproj#20058) Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.24.1 to 4.25.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.25.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: refine deny destination checks (argoproj#20045) * fix: refine server deny check Fixes argoproj#19804. The deny destination check can be made more intuitive by doing the following: * short-circuit any deny destination * first, for any deny server destination, _also_ check if the namespace matches * for any deny namespace destination, reject as before Signed-off-by: Blake Pettersson <[email protected]> * fix: also assert that server matches on ns deny Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: Added unit tests and fix e2e tests for application sync decoupling feature (argoproj#19966) * fixed doc comments and added unit tests Signed-off-by: anandf <[email protected]> * Added comments for the newly added unit tests Signed-off-by: anandf <[email protected]> * Refactored method name to deriveServiceAccountToImpersonate Signed-off-by: anandf <[email protected]> * Using const name in return value Signed-off-by: anandf <[email protected]> * Added unit tests for argocd proj add-destination-service-accounts Signed-off-by: anandf <[email protected]> * Fixed failing e2e tests Signed-off-by: anandf <[email protected]> * Fix linting errors Signed-off-by: anandf <[email protected]> * Using require package instead of assert and fixed code generation Signed-off-by: anandf <[email protected]> * Removed parallel execution of tests for sync with impersonate Signed-off-by: anandf <[email protected]> * Added err checks for glob validations Signed-off-by: anandf <[email protected]> * Fixed e2e tests for sync impersonation Signed-off-by: anandf <[email protected]> * Using consistently based expects in E2E tests Signed-off-by: anandf <[email protected]> * Added more unit tests and fixed go generate Signed-off-by: anandf <[email protected]> * Fixed failed lint errors, unit and e2e test failures Signed-off-by: anandf <[email protected]> * Fixed goimports linter issue Signed-off-by: anandf <[email protected]> * Added code comments and added few missing unit tests Signed-off-by: anandf <[email protected]> * Added missing unit test for GetDestinationServiceAccounts method Signed-off-by: anandf <[email protected]> * Fixed goimports formatting with local for project_test.go Signed-off-by: anandf <[email protected]> * Corrected typo in a field name additionalObjs Signed-off-by: anandf <[email protected]> * Fixed failing unit tests Signed-off-by: anandf <[email protected]> --------- Signed-off-by: anandf <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Fix false positive in plugin application discovery (argoproj#20196) * fix: fix false positive in plugin application discovery Signed-off-by: Pradithya Aria <[email protected]> * fix: apply suggestion to return immediately if discovery is not configured for unnamed plugin Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: update health check to support modelmesh (argoproj#20142) Signed-off-by: Trevor Royer <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: rename protobuf field according to convention (argoproj#20221) Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: add TBC Bank to USERS.md (argoproj#20227) * docs: add TBC Bank to USERS.md Signed-off-by: Mate Gogiberidze <[email protected]> * docs: reorder TBC Bank by alphabetical Signed-off-by: Mate Gogiberidze <[email protected]> --------- Signed-off-by: Mate Gogiberidze <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/setup-buildx-action from 3.6.1 to 3.7.0 (argoproj#20224) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.6.1 to 3.7.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@988b5a0...8026d2b) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump tj-actions/changed-files from 45.0.2 to 45.0.3 (argoproj#20225) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45.0.2 to 45.0.3. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@48d8f15...c3a1bb2) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: use `ErrorContains(t, err` instead of `Contains(t, err.Error()` (argoproj#20220) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: Correct ApplicationSet (spec.preservedFields) (argoproj#20206) * Fix docs Signed-off-by: jyoungs <[email protected]> * Remove another errant block; improved comments Signed-off-by: jyoungs <[email protected]> * Actually removed the errant block Signed-off-by: jyoungs <[email protected]> * More doc fixes Signed-off-by: jyoungs <[email protected]> * More spec fixes + USERS Signed-off-by: jyoungs <[email protected]> --------- Signed-off-by: jyoungs <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(health): only consider non-empty health checks (argoproj#20232) * fix(health): only consider non-empty health checks For wildcard health checks, only consider wildcards with a non-empty health check. Fixes argoproj#16905 (at least partially). Signed-off-by: Blake Pettersson <[email protected]> * test: renaming test case for clarity Signed-off-by: Blake Pettersson <[email protected]> * refactor: add clarity as to what the function is supposed to do Signed-off-by: Blake Pettersson <[email protected]> * Update docs/operator-manual/health.md Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Blake Pettersson <[email protected]> * test: add test case for `*/*` override with empty healthcheck Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: support managing cluster with multiple argocd instances and annotation based tracking (argoproj#20222) Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Moleus <[email protected]> * fix notification-catlog issue (argoproj#20237) Signed-off-by: ajinkyak423 <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(ci): add renovate for golangci-lint, go and node version (argoproj#20236) Signed-off-by: ggjulio <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump actions/cache from 4.0.2 to 4.1.0 (argoproj#20240) Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.1.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0c45773...2cdf405) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/setup-buildx-action from 3.7.0 to 3.7.1 (argoproj#20241) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.7.0 to 3.7.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@8026d2b...c47758b) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/time from 0.6.0 to 0.7.0 (argoproj#20244) Bumps [golang.org/x/time](https://github.com/golang/time) from 0.6.0 to 0.7.0. - [Commits](golang/time@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(cli): Add app diff option to specify exit code when diff (argoproj#20144) The argocd app diff command returns 1 if a difference is found. In related issues, they want to return an error code that is distinguishable from common errors. However, changing the existing behavior is likely to break user's automation code. So we want to provide an explicit option(--diff-exit-code) to specify an error code. Related: argoproj#3588 Signed-off-by: Eugene Kim <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: add support for helm skipTests flag (argoproj#20118) Signed-off-by: jaehanbyun <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump sigstore/cosign-installer from 3.6.0 to 3.7.0 (argoproj#20242) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@4959ce0...dc72c7d) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/term from 0.24.0 to 0.25.0 (argoproj#20245) Bumps [golang.org/x/term](https://github.com/golang/term) from 0.24.0 to 0.25.0. - [Commits](golang/term@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/crypto from 0.27.0 to 0.28.0 (argoproj#20243) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0. - [Commits](golang/crypto@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/net from 0.29.0 to 0.30.0 (argoproj#20246) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.29.0 to 0.30.0. - [Commits](golang/net@v0.29.0...v0.30.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore: update notifications-engine to 22ccfe0caf45 (argoproj#20239) * Update notifications-engine Signed-off-by: SLASHLogin <[email protected]> * Update docs for Opsgenie notifications Signed-off-by: SLASHLogin <[email protected]> * docs: Fix outdated slack notification configuration readme Signed-off-by: SLASHLogin <[email protected]> --------- Signed-off-by: SLASHLogin <[email protected]> Signed-off-by: Moleus <[email protected]> * [Bot] docs: Update Snyk reports (argoproj#20250) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: handle incorrect cluster RESTconfig without panic (argoproj#20150) Signed-off-by: cef <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update node version (argoproj#20248) * chore(deps): update node version * Update ui/.nvmrc Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * sec: update alpine/helm to 3.16.1 (argoproj#20253) Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(ci): update renovate config (argoproj#20254) Signed-off-by: ggjulio <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Policy/policy.open-cluster-management.io health check is broken (argoproj#20108) (argoproj#20109) Tried using the health check as listed here but it gave error: | error setting app health: failed to get resource health for "Policy" with name "XXXX" in namespace "local-cluster": <string>:35: invalid value (nil) at index 1 in table for concat stack traceback: [G]: in function 'concat' <string>:35: in main chunk [G]: ? This change fixes the error by updating how the noncompliant clusters are tracked and counted to use latest Lua recommendations. Signed-off-by: Ian Tewksbury <[email protected]> Signed-off-by: Moleus <[email protected]> * feat(applicationset): Add FlatList option to cluster generator - Fixes argoproj#20212 (argoproj#20231) * (feat) - Add FlatList option to cluster generator Signed-off-by: OpenGuidou <[email protected]> * Update docs/operator-manual/applicationset/Generators-Cluster.md Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update docs dependencies (argoproj#20257) * chore(deps): update docs dependencies Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump rtd python version Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update group golang to v1.23.2 (argoproj#20256) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore: bump k8s versions in e2e tests (argoproj#19669) Signed-off-by: Moleus <[email protected]> --------- Signed-off-by: Moleus <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Symeon Meichanetzoglou <[email protected]> Signed-off-by: linghaoSu <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Tony Au-Yeung <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: CI <[email protected]> Signed-off-by: todaywasawesome <[email protected]> Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Crumbs <[email protected]> Signed-off-by: cef <[email protected]> Signed-off-by: asjervanasten <[email protected]> Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: leehosu <[email protected]> Signed-off-by: l2h <[email protected]> Signed-off-by: nueavv <[email protected]> Signed-off-by: Phong Do <[email protected]> Signed-off-by: KangManJoo <[email protected]> Signed-off-by: daengdaengLee <[email protected]> Signed-off-by: Paul Larsen <[email protected]> Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: anandf <[email protected]> Signed-off-by: Trevor Royer <[email protected]> Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Mate Gogiberidze <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: jyoungs <[email protected]> Signed-off-by: ajinkyak423 <[email protected]> Signed-off-by: ggjulio <[email protected]> Signed-off-by: Eugene Kim <[email protected]> Signed-off-by: jaehanbyun <[email protected]> Signed-off-by: SLASHLogin <[email protected]> Signed-off-by: Ian Tewksbury <[email protected]> Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dan Garfield <[email protected]> Co-authored-by: Cheng Fang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Symeon Meichanetzoglou <[email protected]> Co-authored-by: Linghao Su <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Tony Au-Yeung <[email protected]> Co-authored-by: aria <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: CI <[email protected]> Co-authored-by: Dillen Padhiar <[email protected]> Co-authored-by: Daco <[email protected]> Co-authored-by: Crumbs <[email protected]> Co-authored-by: ABBOUD Moncef <[email protected]> Co-authored-by: appiepollo14 <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Suraj yadav <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: l2h <[email protected]> Co-authored-by: rumstead <[email protected]> Co-authored-by: 1102 <[email protected]> Co-authored-by: Phong Do <[email protected]> Co-authored-by: Olivier Wenger <[email protected]> Co-authored-by: KangManJoo <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Co-authored-by: Paul Larsen <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> Co-authored-by: Anand Francis Joseph <[email protected]> Co-authored-by: Trevor Royer <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Mate Gogiberidze <[email protected]> Co-authored-by: Matthieu MOREL <[email protected]> Co-authored-by: Jeff Youngs <[email protected]> Co-authored-by: Ajinkya Ganesh Kumbhar <[email protected]> Co-authored-by: Julio <[email protected]> Co-authored-by: Eugene Kim <[email protected]> Co-authored-by: 변재한 <[email protected]> Co-authored-by: SLASHLogin <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ian Tewksbury <[email protected]> Co-authored-by: OpenGuidou <[email protected]> Signed-off-by: alnoor <[email protected]>
austin5219
pushed a commit
to austin5219/argo-cd
that referenced
this issue
Oct 16, 2024
* chore(common): Split const from unrelated util/clusterauth const Signed-off-by: Josh Soref <[email protected]> * chore: Try to make CodeQL happy Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]> Signed-off-by: austin5219 <[email protected]>
austin5219
pushed a commit
to austin5219/argo-cd
that referenced
this issue
Oct 16, 2024
…argoproj#20085) * docs: Add `404 Not Found` github notification error to troubleshooting docs Signed-off-by: Moleus <[email protected]> * Update docs/operator-manual/notifications/troubleshooting-errors.md Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * Update docs/operator-manual/notifications/troubleshooting-errors.md Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by upgrading path-to-regexp from 1.8.0 to 1.9.0 (argoproj#20087) Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps-dev): bump @types/node from 22.5.5 to 22.7.2 in /ui-test (argoproj#20112) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.5 to 22.7.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix(extension): add header to support apps-in-any-namespace (argoproj#20123) Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Moleus <[email protected]> * Fix typo (argoproj#20127) Remove a redundant "is". Signed-off-by: Symeon Meichanetzoglou <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(ui): add optional check to avoid undefined reference in project detail (argoproj#20044) Signed-off-by: linghaoSu <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump Helm from 3.15.2 to 3.15.4 (argoproj#20135) * sec: upgrade helm version in order to fix critical vulnerability Signed-off-by: pashakostohrys <[email protected]> * sec: upgrade helm version in order to fix critical vulnerability Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: oras-go client should fallback to docker config if no credentials specified (argoproj#18133) * oras-go client should fallback to docker config if no credentials specified Signed-off-by: Tony Au-Yeung <[email protected]> * Fix tests Signed-off-by: Tony Au-Yeung <[email protected]> * Fix lint Signed-off-by: Tony Au-Yeung <[email protected]> * gofumpt Signed-off-by: Tony Au-Yeung <[email protected]> * Validate auth header Signed-off-by: Tony Au-Yeung <[email protected]> --------- Signed-off-by: Tony Au-Yeung <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (argoproj#20154) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.7.0 to 6.8.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@5cd11c3...32945a3) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: Fix argocd appset generate failure due to missing clusterrole (argoproj#20162) * fix: FIx argocd-server clusterrole to allow argocd appset generate using cluster generator Signed-off-by: Pradithya Aria <[email protected]> * fix: update generated code Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Moleus <[email protected]> * [Bot] docs: Update Snyk reports (argoproj#20146) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: repo generate paths value in namespace install is incorrectly formatted (argoproj#20139) * Fix repo generate paths value in namespace install Signed-off-by: todaywasawesome <[email protected]> * Fix in base and regen Signed-off-by: todaywasawesome <[email protected]> --------- Signed-off-by: todaywasawesome <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: introduce pause/unpause actions for Numaplane CRDs (argoproj#20128) * feat: introduce pause/unpause actions for Numaplane CRDs Signed-off-by: Dillen Padhiar <[email protected]> * test: fixed incorrect file names Signed-off-by: Dillen Padhiar <[email protected]> * chore: codegen Signed-off-by: Dillen Padhiar <[email protected]> * fix: empty check for lifecycle Signed-off-by: Dillen Padhiar <[email protected]> * fix: nil check Signed-off-by: Dillen Padhiar <[email protected]> * fix: nil checks Signed-off-by: Dillen Padhiar <[email protected]> * test: testing different starting spec Signed-off-by: Dillen Padhiar <[email protected]> * feat: add nil checks for all possible nil fields Signed-off-by: Dillen Padhiar <[email protected]> * chore: rerun tests Signed-off-by: Dillen Padhiar <[email protected]> --------- Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Moleus <[email protected]> * feat(appset): Add a cache layer for Argo Projects to speed-up application validation (argoproj#18703) * feat(appset): Add a cache layer for Argo Projects to speed-up application validation Signed-off-by: Philippe Da Costa <[email protected]> * Use local client rather than custom cache Signed-off-by: Philippe Da Costa <[email protected]> * Clean go.mod Signed-off-by: Philippe Da Costa <[email protected]> * Merge master Signed-off-by: Philippe Da Costa <[email protected]> * Fix after merging master Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> * Initialize appProject variable inside loop Signed-off-by: Philippe Da Costa <[email protected]> * Remove unused ArgoAppClientset field Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> * Fix linter issue Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> --------- Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: added note re. arch of example application on getting_started.md (argoproj#20143) added warning that example application may not run on all archs Signed-off-by: Crumbs <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(ui): hide resource actions menu if it's empty (argoproj#20051) Signed-off-by: cef <[email protected]> Signed-off-by: Moleus <[email protected]> * Fixes minor typo which lead to using the bearer token as api URL and was obviously not working. (argoproj#20169) Signed-off-by: asjervanasten <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: Try to make CodeQL happy (argoproj#20094) (argoproj#20129) * chore(common): Split const from unrelated util/clusterauth const Signed-off-by: Josh Soref <[email protected]> * chore: Try to make CodeQL happy Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (argoproj#20174) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@32945a3...4f58ea7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(ui): make name property for repos (argoproj#20077) * name-option-added Signed-off-by: Surajyadav <[email protected]> * lint Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: basic e2e tests in order to verify notification service health (argoproj#20182) * feat: basic e2e tests in order to verify notification service health Signed-off-by: pashakostohrys <[email protected]> * feat: basic e2e tests in order to verify notification service health Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: document credentials server (argoproj#20078) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: Add nodeSelector for Linux nodes (argoproj#20148) * feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server Signed-off-by: leehosu <[email protected]> * refactor : Reversal the wrong part and correct it. Signed-off-by: leehosu <[email protected]> * Update argocd-application-controller-statefulset.yaml Signed-off-by: l2h <[email protected]> * feat: Add nodeSelector for Linux nodes in dex-server, argo-server Signed-off-by: leehosu <[email protected]> * refactor: update code to resolving for intergration test Signed-off-by: leehosu <[email protected]> * refactor: update code to resolving for codegen Signed-off-by: leehosu <[email protected]> * Run make manifests-local and then commit Signed-off-by: leehosu <[email protected]> --------- Signed-off-by: leehosu <[email protected]> Signed-off-by: l2h <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump github.com/cyphar/filepath-securejoin (argoproj#20173) Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.2 to 0.3.3. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md) - [Commits](cyphar/filepath-securejoin@v0.3.2...v0.3.3) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(appset): parameterize requeue time argoproj#20063 (argoproj#20064) Signed-off-by: Moleus <[email protected]> * chore(ci): better handling of Go and Node dependency bumps (argoproj#20168) * chore(ci): better handling of Go and Node dependency bumps Signed-off-by: Michael Crenshaw <[email protected]> temporarily remove condition Signed-off-by: Michael Crenshaw <[email protected]> quit early if there are no changes Signed-off-by: Michael Crenshaw <[email protected]> use latest checkout action and actually test version change Signed-off-by: Michael Crenshaw <[email protected]> use github token Signed-off-by: Michael Crenshaw <[email protected]> workflow for node Signed-off-by: Michael Crenshaw <[email protected]> clean up after changing node version Signed-off-by: Michael Crenshaw <[email protected]> revert temporary changes Signed-off-by: Michael Crenshaw <[email protected]> more docs Signed-off-by: Michael Crenshaw <[email protected]> * bump linter version Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump codecov/codecov-action from 4.5.0 to 4.6.0 (argoproj#20188) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@e28ff12...b9fd7d1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * docs(ui): sorting version (argoproj#20181) Signed-off-by: nueavv <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: add outpost24 to users.md (argoproj#20197) Signed-off-by: Phong Do <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: Update argocd path for command in notifification in troubleshooting docs (argoproj#20120) Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump google.golang.org/grpc from 1.67.0 to 1.67.1 (argoproj#20190) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.67.0 to 1.67.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.67.0...v1.67.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump chromedriver from 129.0.0 to 129.0.2 in /ui-test (argoproj#20189) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 129.0.0 to 129.0.2. - [Commits](giggio/node-chromedriver@129.0.0...129.0.2) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump bitnami/kubectl in /test/container (argoproj#20191) Bumps bitnami/kubectl from `da4a986` to `b509ab6`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump library/busybox in /test/e2e/multiarch-container (argoproj#20193) Bumps library/busybox from `c230832` to `768e5c6`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix(helm): escape consecutive commas in cleanSetParameters (argoproj#19269) (argoproj#20113) Signed-off-by: KangManJoo <[email protected]> Signed-off-by: daengdaengLee <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Signed-off-by: Moleus <[email protected]> * Update troubleshooting-errors.md (argoproj#20201) Fixing some phrasing and adding more clarity. Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Rework git tag semver resolution (argoproj#20083) (argoproj#20096) * Write initial tests Signed-off-by: Paul Larsen <[email protected]> * Improve git tag semver resolution Signed-off-by: Paul Larsen <[email protected]> * Add company to list of users Signed-off-by: Paul Larsen <[email protected]> * Fix broken error string check Signed-off-by: Paul Larsen <[email protected]> * Fix incorrect semver test assumption Signed-off-by: Paul Larsen <[email protected]> * switch to debug statement Signed-off-by: Paul Larsen <[email protected]> * Add more testcases for review Signed-off-by: Paul Larsen <[email protected]> * review comments Signed-off-by: Paul Larsen <[email protected]> --------- Signed-off-by: Paul Larsen <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (argoproj#20207) Signed-off-by: Moleus <[email protected]> * feat(ui): support auto theme (argoproj#20080) * feat(theme): support auto theme Signed-off-by: linghaoSu <[email protected]> * fix(ui): set default theme as light Signed-off-by: linghaoSu <[email protected]> * fix(ui): only register listener when theme is auto Signed-off-by: linghaoSu <[email protected]> --------- Signed-off-by: linghaoSu <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump selenium-webdriver from 4.24.1 to 4.25.0 in /ui-test (argoproj#20058) Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.24.1 to 4.25.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.25.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: refine deny destination checks (argoproj#20045) * fix: refine server deny check Fixes argoproj#19804. The deny destination check can be made more intuitive by doing the following: * short-circuit any deny destination * first, for any deny server destination, _also_ check if the namespace matches * for any deny namespace destination, reject as before Signed-off-by: Blake Pettersson <[email protected]> * fix: also assert that server matches on ns deny Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: Added unit tests and fix e2e tests for application sync decoupling feature (argoproj#19966) * fixed doc comments and added unit tests Signed-off-by: anandf <[email protected]> * Added comments for the newly added unit tests Signed-off-by: anandf <[email protected]> * Refactored method name to deriveServiceAccountToImpersonate Signed-off-by: anandf <[email protected]> * Using const name in return value Signed-off-by: anandf <[email protected]> * Added unit tests for argocd proj add-destination-service-accounts Signed-off-by: anandf <[email protected]> * Fixed failing e2e tests Signed-off-by: anandf <[email protected]> * Fix linting errors Signed-off-by: anandf <[email protected]> * Using require package instead of assert and fixed code generation Signed-off-by: anandf <[email protected]> * Removed parallel execution of tests for sync with impersonate Signed-off-by: anandf <[email protected]> * Added err checks for glob validations Signed-off-by: anandf <[email protected]> * Fixed e2e tests for sync impersonation Signed-off-by: anandf <[email protected]> * Using consistently based expects in E2E tests Signed-off-by: anandf <[email protected]> * Added more unit tests and fixed go generate Signed-off-by: anandf <[email protected]> * Fixed failed lint errors, unit and e2e test failures Signed-off-by: anandf <[email protected]> * Fixed goimports linter issue Signed-off-by: anandf <[email protected]> * Added code comments and added few missing unit tests Signed-off-by: anandf <[email protected]> * Added missing unit test for GetDestinationServiceAccounts method Signed-off-by: anandf <[email protected]> * Fixed goimports formatting with local for project_test.go Signed-off-by: anandf <[email protected]> * Corrected typo in a field name additionalObjs Signed-off-by: anandf <[email protected]> * Fixed failing unit tests Signed-off-by: anandf <[email protected]> --------- Signed-off-by: anandf <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Fix false positive in plugin application discovery (argoproj#20196) * fix: fix false positive in plugin application discovery Signed-off-by: Pradithya Aria <[email protected]> * fix: apply suggestion to return immediately if discovery is not configured for unnamed plugin Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: update health check to support modelmesh (argoproj#20142) Signed-off-by: Trevor Royer <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Moleus <[email protected]> * chore: rename protobuf field according to convention (argoproj#20221) Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: add TBC Bank to USERS.md (argoproj#20227) * docs: add TBC Bank to USERS.md Signed-off-by: Mate Gogiberidze <[email protected]> * docs: reorder TBC Bank by alphabetical Signed-off-by: Mate Gogiberidze <[email protected]> --------- Signed-off-by: Mate Gogiberidze <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/setup-buildx-action from 3.6.1 to 3.7.0 (argoproj#20224) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.6.1 to 3.7.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@988b5a0...8026d2b) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump tj-actions/changed-files from 45.0.2 to 45.0.3 (argoproj#20225) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45.0.2 to 45.0.3. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@48d8f15...c3a1bb2) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * fix: use `ErrorContains(t, err` instead of `Contains(t, err.Error()` (argoproj#20220) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Moleus <[email protected]> * docs: Correct ApplicationSet (spec.preservedFields) (argoproj#20206) * Fix docs Signed-off-by: jyoungs <[email protected]> * Remove another errant block; improved comments Signed-off-by: jyoungs <[email protected]> * Actually removed the errant block Signed-off-by: jyoungs <[email protected]> * More doc fixes Signed-off-by: jyoungs <[email protected]> * More spec fixes + USERS Signed-off-by: jyoungs <[email protected]> --------- Signed-off-by: jyoungs <[email protected]> Signed-off-by: Moleus <[email protected]> * fix(health): only consider non-empty health checks (argoproj#20232) * fix(health): only consider non-empty health checks For wildcard health checks, only consider wildcards with a non-empty health check. Fixes argoproj#16905 (at least partially). Signed-off-by: Blake Pettersson <[email protected]> * test: renaming test case for clarity Signed-off-by: Blake Pettersson <[email protected]> * refactor: add clarity as to what the function is supposed to do Signed-off-by: Blake Pettersson <[email protected]> * Update docs/operator-manual/health.md Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Blake Pettersson <[email protected]> * test: add test case for `*/*` override with empty healthcheck Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: support managing cluster with multiple argocd instances and annotation based tracking (argoproj#20222) Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Moleus <[email protected]> * fix notification-catlog issue (argoproj#20237) Signed-off-by: ajinkyak423 <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(ci): add renovate for golangci-lint, go and node version (argoproj#20236) Signed-off-by: ggjulio <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump actions/cache from 4.0.2 to 4.1.0 (argoproj#20240) Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.1.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0c45773...2cdf405) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump docker/setup-buildx-action from 3.7.0 to 3.7.1 (argoproj#20241) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.7.0 to 3.7.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@8026d2b...c47758b) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/time from 0.6.0 to 0.7.0 (argoproj#20244) Bumps [golang.org/x/time](https://github.com/golang/time) from 0.6.0 to 0.7.0. - [Commits](golang/time@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * feat(cli): Add app diff option to specify exit code when diff (argoproj#20144) The argocd app diff command returns 1 if a difference is found. In related issues, they want to return an error code that is distinguishable from common errors. However, changing the existing behavior is likely to break user's automation code. So we want to provide an explicit option(--diff-exit-code) to specify an error code. Related: argoproj#3588 Signed-off-by: Eugene Kim <[email protected]> Signed-off-by: Moleus <[email protected]> * feat: add support for helm skipTests flag (argoproj#20118) Signed-off-by: jaehanbyun <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): bump sigstore/cosign-installer from 3.6.0 to 3.7.0 (argoproj#20242) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@4959ce0...dc72c7d) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/term from 0.24.0 to 0.25.0 (argoproj#20245) Bumps [golang.org/x/term](https://github.com/golang/term) from 0.24.0 to 0.25.0. - [Commits](golang/term@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/crypto from 0.27.0 to 0.28.0 (argoproj#20243) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0. - [Commits](golang/crypto@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore(deps): bump golang.org/x/net from 0.29.0 to 0.30.0 (argoproj#20246) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.29.0 to 0.30.0. - [Commits](golang/net@v0.29.0...v0.30.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore: update notifications-engine to 22ccfe0caf45 (argoproj#20239) * Update notifications-engine Signed-off-by: SLASHLogin <[email protected]> * Update docs for Opsgenie notifications Signed-off-by: SLASHLogin <[email protected]> * docs: Fix outdated slack notification configuration readme Signed-off-by: SLASHLogin <[email protected]> --------- Signed-off-by: SLASHLogin <[email protected]> Signed-off-by: Moleus <[email protected]> * [Bot] docs: Update Snyk reports (argoproj#20250) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: handle incorrect cluster RESTconfig without panic (argoproj#20150) Signed-off-by: cef <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update node version (argoproj#20248) * chore(deps): update node version * Update ui/.nvmrc Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * sec: update alpine/helm to 3.16.1 (argoproj#20253) Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(ci): update renovate config (argoproj#20254) Signed-off-by: ggjulio <[email protected]> Signed-off-by: Moleus <[email protected]> * fix: Policy/policy.open-cluster-management.io health check is broken (argoproj#20108) (argoproj#20109) Tried using the health check as listed here but it gave error: | error setting app health: failed to get resource health for "Policy" with name "XXXX" in namespace "local-cluster": <string>:35: invalid value (nil) at index 1 in table for concat stack traceback: [G]: in function 'concat' <string>:35: in main chunk [G]: ? This change fixes the error by updating how the noncompliant clusters are tracked and counted to use latest Lua recommendations. Signed-off-by: Ian Tewksbury <[email protected]> Signed-off-by: Moleus <[email protected]> * feat(applicationset): Add FlatList option to cluster generator - Fixes argoproj#20212 (argoproj#20231) * (feat) - Add FlatList option to cluster generator Signed-off-by: OpenGuidou <[email protected]> * Update docs/operator-manual/applicationset/Generators-Cluster.md Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update docs dependencies (argoproj#20257) * chore(deps): update docs dependencies Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump rtd python version Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Moleus <[email protected]> * chore(deps): update group golang to v1.23.2 (argoproj#20256) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Moleus <[email protected]> * chore: bump k8s versions in e2e tests (argoproj#19669) Signed-off-by: Moleus <[email protected]> --------- Signed-off-by: Moleus <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Symeon Meichanetzoglou <[email protected]> Signed-off-by: linghaoSu <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Tony Au-Yeung <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: CI <[email protected]> Signed-off-by: todaywasawesome <[email protected]> Signed-off-by: Dillen Padhiar <[email protected]> Signed-off-by: Philippe Da Costa <[email protected]> Signed-off-by: Crumbs <[email protected]> Signed-off-by: cef <[email protected]> Signed-off-by: asjervanasten <[email protected]> Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: leehosu <[email protected]> Signed-off-by: l2h <[email protected]> Signed-off-by: nueavv <[email protected]> Signed-off-by: Phong Do <[email protected]> Signed-off-by: KangManJoo <[email protected]> Signed-off-by: daengdaengLee <[email protected]> Signed-off-by: Paul Larsen <[email protected]> Signed-off-by: Blake Pettersson <[email protected]> Signed-off-by: anandf <[email protected]> Signed-off-by: Trevor Royer <[email protected]> Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Mate Gogiberidze <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: jyoungs <[email protected]> Signed-off-by: ajinkyak423 <[email protected]> Signed-off-by: ggjulio <[email protected]> Signed-off-by: Eugene Kim <[email protected]> Signed-off-by: jaehanbyun <[email protected]> Signed-off-by: SLASHLogin <[email protected]> Signed-off-by: Ian Tewksbury <[email protected]> Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dan Garfield <[email protected]> Co-authored-by: Cheng Fang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Symeon Meichanetzoglou <[email protected]> Co-authored-by: Linghao Su <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Tony Au-Yeung <[email protected]> Co-authored-by: aria <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: CI <[email protected]> Co-authored-by: Dillen Padhiar <[email protected]> Co-authored-by: Daco <[email protected]> Co-authored-by: Crumbs <[email protected]> Co-authored-by: ABBOUD Moncef <[email protected]> Co-authored-by: appiepollo14 <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Suraj yadav <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: l2h <[email protected]> Co-authored-by: rumstead <[email protected]> Co-authored-by: 1102 <[email protected]> Co-authored-by: Phong Do <[email protected]> Co-authored-by: Olivier Wenger <[email protected]> Co-authored-by: KangManJoo <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Co-authored-by: Paul Larsen <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> Co-authored-by: Anand Francis Joseph <[email protected]> Co-authored-by: Trevor Royer <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Mate Gogiberidze <[email protected]> Co-authored-by: Matthieu MOREL <[email protected]> Co-authored-by: Jeff Youngs <[email protected]> Co-authored-by: Ajinkya Ganesh Kumbhar <[email protected]> Co-authored-by: Julio <[email protected]> Co-authored-by: Eugene Kim <[email protected]> Co-authored-by: 변재한 <[email protected]> Co-authored-by: SLASHLogin <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ian Tewksbury <[email protected]> Co-authored-by: OpenGuidou <[email protected]> Signed-off-by: austin5219 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
CodeQL has resulted in a number of false positives/low grade issues. Given that it's going to continue to be used, it seems like it may be worth it to acede to some of its demands. One of the is to not call a field that references a password a password (or a secret), but just anything that isn't a password, since it isn't the password, it's just something else.
Motivation
CodeQL will complain about this:
cmd/argocd/commands/admin/redis_initial_password.go:50
CodeQL
Proposal
Rename fields from
PasswordSecret
toCredentials
andPasswordKey
toCredentialsKey
because the busywork definition doesn't include it:https://github.com/github/codeql/blob/590e93d8edec4d7216935ed4425a7ab77b3b2f34/go/ql/lib/semmle/go/security/SensitiveActions.qll#L87-L101
Thus,
Yes, I'm aware that the Kubernetes type
Secret
is washed away fromredisInitialCredentialsName
, as it's more or less locally used right next tosecret %s/%s
, I don't think that's particularly problematic.No, I'm not a huge fan of this exercise, but, having just filed a bunch of bugs against CodeQL and closed a bunch of tickets here, I'd rather not spend time closing more tickets here if we can fairly easily appease CodeQL and not cause us too much grief in the process.
This issue is submitted under protest.
The text was updated successfully, but these errors were encountered: