chore: update notifications-engine to f4856710 #17971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspj
force-pushed
the
chore/update-notifications-engine
branch
from
1eed7f3
to
42e384b
Compare
lukaspj
changed the title
Signed-off-by: Lukas Peter Aldershaab <[email protected]>
Signed-off-by: Lukas Peter Aldershaab <[email protected]>
Signed-off-by: Lukas Peter Aldershaab <[email protected]>
lukaspj
force-pushed
the
chore/update-notifications-engine
branch
from
010938e
to
14faf7c
Compare
|
I’m struggling with getting the codegen to work on my laptop, various permission errors,I will try and dig around and see if I can get it to run. |
|
@lukaspj , you can add me as collaborator to your fork, so i can help you with codegen |
Thanks! I suspect I’m having issues because my container runtime is not running with root access |
lukaspj
changed the title
Signed-off-by: pashakostohrys <[email protected]>
pasha-codefresh
approved these changes
Apr 28, 2024
|
Is it too late to cherry pick this PR into 2.11 release? |
|
/cherry-pick release-2.11 |
|
Cherry-pick failed with |
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
* update notifications-engine Signed-off-by: Lukas Peter Aldershaab <[email protected]> * Fix build of conflicting git-urls libraries Signed-off-by: Lukas Peter Aldershaab <[email protected]> * align telegrom dependency with notifications-engine Signed-off-by: Lukas Peter Aldershaab <[email protected]> * fix: codegen Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: Lukas Peter Aldershaab <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Co-authored-by: pashakostohrys <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* update notifications-engine Signed-off-by: Lukas Peter Aldershaab <[email protected]> * Fix build of conflicting git-urls libraries Signed-off-by: Lukas Peter Aldershaab <[email protected]> * align telegrom dependency with notifications-engine Signed-off-by: Lukas Peter Aldershaab <[email protected]> * fix: codegen Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: Lukas Peter Aldershaab <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Co-authored-by: pashakostohrys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to argoproj/notifications-engine@f485671, changes since current version:
In order to achieve this I had to align the telegram reference by adding:
https://github.com/argoproj/argo-cd/pull/17971/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R300
And permanently replace whilp/git-urls with chainguard-dev/git-urls to avoid a conflict between notifications-engine and the dependencies in ArgoCD:
https://github.com/argoproj/argo-cd/pull/17971/files#diff-9bf515f23994401fc8c2f43c5f95b5dcb70a5df95fe7f6ba106d87b809cc9568R16
Checklist:
I think this might be more a request than an actual PR since I'm not sure exactly what to test for here to validate the changes.
notifications-engine hasn't been updated since February, and we'd really like some of the changes made, especially the one from the 7th of February. We can also see that there have been at least one CVE fixed.
I don't know if there's a reason that notifications-engine hasn't been updated but I wanted to at least highlight it. Feel free to close this PR if I'm missing some obvious reason that updates of notifications-engine has been stalled.